fix: resolve spec paths relative to package install dir#66
Merged
Conversation
The get_spec_dict function used a relative path (farialimer/specs/{provider})
which only works when the CWD contains the farialimer source tree. When
farialimer is installed as a package and imported from another project,
os.walk finds nothing and returns an empty dict, breaking all parsers
and generators.
Fix: resolve the specs directory relative to __file__ so it works
regardless of the caller's working directory.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_spec_dictinfarialimer/utils/spec_loader.pyused a relative path (farialimer/specs/{provider}) that only works when the current working directory contains the farialimer source tree. When farialimer is installed as a package and imported from another project,os.walkfinds nothing and returns an empty dict, breaking all parsers and generators.__file__usingos.path.dirnameso the path is always correct regardless of the caller's working directory.Test plan
🤖 Generated with Claude Code