pipeline: defer processor close in pool until all workers exit#393
Merged
pipeline: defer processor close in pool until all workers exit#393
Conversation
|
Commits Review LGTM |
mmatczuk
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When pipeline.threads > 1, all worker goroutines share the same processor instances. Previously, when any worker's input channel closed, its loop() defer would call Close() on the shared processors — even while other workers were still mid-processing. This caused errors like "sql: database is closed".
Add a noCloseProcs flag to Processor so that pool workers skip closing processors in their defer. Instead, Pool.loop() closes the shared processors after all workers have exited.
Fixes redpanda-data/connect#1655