Skip to content

env: handle Windows line terminators in dotenv parser#394

Merged
mmatczuk merged 3 commits intomainfrom
connect-1820
Mar 19, 2026
Merged

env: handle Windows line terminators in dotenv parser#394
mmatczuk merged 3 commits intomainfrom
connect-1820

Conversation

@twmb
Copy link
Copy Markdown
Contributor

@twmb twmb commented Mar 16, 2026

@claude
Copy link
Copy Markdown

claude bot commented Mar 19, 2026

Commits
LGTM

Review
Clean, well-scoped fix adding \r\n (Windows line ending) support to the dotenv parser. The EmptyLine combinator now recognizes \r\n, and NotInSet calls in the parser correctly exclude \r from key/value content. Good test coverage with six new cases covering Windows, mixed, quoted, comment, and empty-line scenarios.

LGTM

Copy link
Copy Markdown
Contributor

@mmatczuk mmatczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmatczuk mmatczuk merged commit 6cb9c0a into main Mar 19, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flag --env-file doesn't handle Windows line terminators correctly

2 participants