aws_s3: add TLS config option (input/output/cache)#3569
Open
srenatus wants to merge 1 commit intoredpanda-data:mainfrom
Open
aws_s3: add TLS config option (input/output/cache)#3569srenatus wants to merge 1 commit intoredpanda-data:mainfrom
srenatus wants to merge 1 commit intoredpanda-data:mainfrom
Conversation
29d1f4d to
f3862a1
Compare
This change makes TLS configurable for the S3 components (input, output, and cache). There are more callers to GetSession(), but if I understand it correctly, these are AWS-specific services (DynamoDB, Bedrock, ...) and using those components with drop-ins might not be as common as having a different, compatible S3 endpoint. Signed-off-by: Stephan Renatus <stephan@styra.com>
f3862a1 to
d787dd8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes TLS configurable for the S3 components (input, output, and cache).
There are more callers to GetSession(), but if I understand it correctly, these are AWS-specific services (DynamoDB, Bedrock, ...) and using those components with drop-ins might not be as common as having a different, compatible S3 endpoint.