Skip to content

oracle_cdc: reduce the number of log files loaded into LogMiner.#4110

Merged
josephwoodward merged 2 commits intomainfrom
jw/oracledb_cdc_reduce_logfiles
Mar 18, 2026
Merged

oracle_cdc: reduce the number of log files loaded into LogMiner.#4110
josephwoodward merged 2 commits intomainfrom
jw/oracledb_cdc_reduce_logfiles

Conversation

@josephwoodward
Copy link
Copy Markdown
Contributor

@josephwoodward josephwoodward commented Mar 16, 2026

A small change that reduces the number of redo logs returned to just those that include the SCN window we're interested in.

*Includes a small fix for a more graceful shutdown when the component starts in an unhealthy state due to the database being down.

Proof of Work

image

@claude
Copy link
Copy Markdown

claude bot commented Mar 16, 2026

Commits
LGTM

Review
The change narrows log file collection in LogMiner by adding an endSCN upper bound to both the online redo log and archive log SQL queries, so only files whose SCN range overlaps [startSCN, endSCN] are returned. The signature change is propagated correctly to the single call site. Oracle bind variable reuse across the UNION is correct.

LGTM

@josephwoodward josephwoodward force-pushed the jw/oracledb_cdc_reduce_logfiles branch from cf584d6 to 5f49862 Compare March 17, 2026 10:34
@josephwoodward josephwoodward marked this pull request as ready for review March 17, 2026 10:35
@claude
Copy link
Copy Markdown

claude bot commented Mar 17, 2026

Commits
LGTM

Review
Narrows LogMiner log file collection to only files whose SCN range overlaps [startSCN, endSCN], avoiding unnecessary log processing. Also cleans up Debezium references in comments.

LGTM

@claude
Copy link
Copy Markdown

claude bot commented Mar 17, 2026

Commits
LGTM

Review
Two clean, focused changes: (1) bounds the log file query to only collect files whose SCN range overlaps the requested window, avoiding unnecessary log file processing, and (2) fixes cache assignment in Connect() by using a local variable before assigning to the struct field.

LGTM

@claude
Copy link
Copy Markdown

claude bot commented Mar 17, 2026

Commits

  1. fix: something (e55ff33) — Commit message is vague and does not describe what was actually fixed. Per commit policy, messages must not be vague ("fix stuff", "updates", "WIP") and should accurately reflect the changes.

Review
Code changes are correct and well-scoped. The cache assignment fix properly separates error handling from struct field assignment, and the GetLogs SCN range filtering logic is sound.

LGTM

@josephwoodward josephwoodward force-pushed the jw/oracledb_cdc_reduce_logfiles branch from e55ff33 to e11cbd5 Compare March 17, 2026 10:56
@claude
Copy link
Copy Markdown

claude bot commented Mar 17, 2026

Commits
LGTM

Review
Two clean changes: (1) GetLogs now filters log files by SCN range overlap instead of a single offset, reducing unnecessary log file processing, and (2) the checkpoint cache assignment is refactored for clarity. Comment cleanup removes stale Debezium references.

LGTM

@josephwoodward josephwoodward merged commit 76d2e4a into main Mar 18, 2026
7 checks passed
@josephwoodward josephwoodward deleted the jw/oracledb_cdc_reduce_logfiles branch March 18, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants