Docs/extracting data with mapstate #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-redux-docs ready! Built with commit 9526155 |
markerikson
reviewed
Oct 7, 2018
| `mapStateToProps` should be defined as a function: | ||
|
|
||
| ```jsx | ||
| function mapStateToProps(state[, ownProps]) |
There was a problem hiding this comment.
What's the TS/Flow syntax for optional arguments? I've seen the square-bracket syntax used for years with other languages and such, but wondering how helpful it is and how many people recognize that.
There was a problem hiding this comment.
In FlowType it would look like:
/* @flow */
type State = Object; // type for state
type Props = Object; // type of ownProps
type StateProps = Object; // type of StateProps
type mapStateToProps = (state: State, ownProps?: Props) => StateProps
|
I love it. MERGING! |
albertodev7
pushed a commit
to albertodev7/react-redux
that referenced
this pull request
Dec 8, 2022
* Fix typo and remove unnecessary comments from `GettingStarted.md` * Rename getting started to kebab * Add mapState piece * Restructure the mapState page content * Tweak sidebar title and add memoization note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
New doc piece regarding #1001:
Connect: Extracting Data with
mapStateToPropsSummary of the changes
GettingStarted.mdtogetting-started.mdmapStatepiece and set it up on doc site accordingly