-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add catchSchemaFailure
, and docs for RTKQ schema features
#4934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a1db464:
|
size-limit report 📦
|
1aa20f6
to
79d1dec
Compare
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This addresses the concerns I mentioned in the original standard schema MR for catching errors and providing the ability to log the "parse issue" errors to the console (I didn't realize I looked in Zod's source code to see what formatting of With the code snippet below, I no longer see "uncaught error" in console and am able to see all "issues" formatted verbatim the way i'm used to when directly using Zod 👍
First screenshot is my current Zod integration output, second screenshot is RTKQ test PR standard schema validation output |
Other things I noticed:
|
re: type error, try adding i think it makes sense for onSchemaFailure to still be called, so I'll restructure that soon. |
replaces #4926