Open
Conversation
Contributor
|
We've had the capability of validating against the schema for a while, via |
Collaborator
Author
|
Yes, this is the idea and also to have better feedback. There also was no public API for that header validation and it did not seem to work in all cases that I tried using the schema. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out by @andyfaff in #143 it can be hard to validate the Orso header data and find out which attributes are missing/wrong. This adds a
check_validmethod to each Header derived class that can be used to check a dictionary for correctness and get detailed information on the issues if it is invalid.The returned class includes a list of any missing or invalid attributes as well as sub-attribute details. with
ORSOValidationResult.get_report()the results are summarized so users of the API can quickly fix what is missing.Examples:
This should work arbitrarily deep, as illustrated by putting the previous result into a DataSource: