Skip to content

test dynamic route flakiness (can't reproduce locally) #4496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 6, 2024
Merged

test dynamic route flakiness (can't reproduce locally) #4496

merged 2 commits into from
Dec 6, 2024

Conversation

@benedikt-bartscher
Copy link
Contributor

@benedikt-bartscher benedikt-bartscher commented Dec 6, 2024

No description provided.

@benedikt-bartscher
Copy link
Contributor Author

benedikt-bartscher commented Dec 6, 2024

Temporal mitigation until #4446 is ready
CI ran 2 times without failure

@benedikt-bartscher benedikt-bartscher marked this pull request as ready for review December 6, 2024 13:21
Lendemor
Lendemor approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@Lendemor Lendemor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, #4446 is blocked until playwright solve the issue on redirect upstream I think.

So this will do until then 👍

@Lendemor Lendemor merged commit 3a225c2 into reflex-dev:main Dec 6, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Lendemor Lendemor Lendemor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@benedikt-bartscher @Lendemor