Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flake8 test_helpers.py #1188

Open
wants to merge 1 commit into
base: cookie
Choose a base branch
from

Conversation

tinatn29
Copy link
Contributor

@tinatn29 tinatn29 commented Nov 8, 2024

fix #1184 (lines too long)

@tinatn29 tinatn29 changed the title fix flake8 #1184 fix flake8 test_helpers.py Nov 8, 2024
@bobleesj
Copy link

bobleesj commented Nov 8, 2024

fix issue #1184 (lines too long)

Thanks Tina, to automatically close the issue, could you please check the link below?

I wasn't sure whether fix issue ... works.

Ref:
https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue

@tinatn29
Copy link
Contributor Author

tinatn29 commented Nov 12, 2024

Can we merge this one into cookie? (or let me know if there's anything to fix here!)
Do we manually close #1184 or will we close once we merge cookie into main?

@tinatn29
Copy link
Contributor Author

tinatn29 commented Nov 12, 2024

actually it might be better to not merge this one yet? I'm not 100% sure that during this fix I had kept the same amount of trailing spaces, which might make tests (perhaps unnecessary) fail?

(On a different branch I'm dealing with failing tests right now with Assertion errors, where expected and actual outputs are the same texts but with maybe some spacing differences...)

@sbillinge
Copy link
Contributor

OK, I will wait to merge this.

@sbillinge
Copy link
Contributor

@tinatn29 please can you give an update on where we are with the cookiecut? I would like to get the tests passing, but when I checked, they still have not been moved over to regolith/tests. Are there other biggish changes that still need to be done.

Ideally we would have gotten the tests working before too much of the cookiecutting to avoid having to merge too much stuff with failing tests. Most of the cookiecutting doesn't break things, but it is just more confidence inspiring if tests are passing after each step of teh cookie cutting rather than waiting until the end....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants