Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch server.hot to server.ws for vite #13132

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

fahhem
Copy link

@fahhem fahhem commented Feb 28, 2025

Honestly, I don't know what I'm doing here. However, the ViteDevServer (https://vite.dev/guide/api-javascript.html#vitedevserver) doesn't seem to have a hot attribute, only ws. and this change fixes the error I was seeing (specifically, Cannot read properties of undefined (reading 'send')), so 🤷‍♂️ here's a PR!

Copy link

changeset-bot bot commented Feb 28, 2025

⚠️ No Changeset found

Latest commit: 77ef91b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Feb 28, 2025

Hi @fahhem,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Feb 28, 2025

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@markdalgleish
Copy link
Member

I haven't see this error myself — are you able to share a repro?

@timdorr
Copy link
Member

timdorr commented Mar 4, 2025

Note that these are both supported, but it should probably be left as-is:

https://github.com/vitejs/vite/blob/c0e68da4774f3487e9ba0c4d4d2c5e76bdc890ea/packages/vite/src/node/server/index.ts#L272-L282

ws is just the generic WebSocket for communication with the browser. hot uses that, but also allows pluggability into the HMR messages so that other systems/plugins can subscribe as well. Practically, they may be equivalent, but it sounds like hot is the better option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants