Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not throw if the url hash is not a valid URI component #13247

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Do not throw if the url hash is not a valid URI component #13247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da08e79
Update lib.tsx
vezaynk Mar 17, 2025
ef83f13
Update contributors.yml
vezaynk Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions contributors.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,7 @@
- valerii15298
- ValiantCat
- vdusart
- vezaynk
- VictorElHajj
- vijaypushkin
- vikingviolinist
Expand Down
21 changes: 14 additions & 7 deletions packages/react-router/lib/dom/lib.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2083,14 +2083,21 @@ export function useScrollRestoration({
}

// try to scroll to the hash
if (location.hash) {
let el = document.getElementById(
decodeURIComponent(location.hash.slice(1))
);
if (el) {
el.scrollIntoView();
return;
try {
if (location.hash) {
let el = document.getElementById(
decodeURIComponent(location.hash.slice(1))
);
if (el) {
el.scrollIntoView();
return;
}
}
} catch {
warning(
false,
`"${location.hash.slice(1)}" is not a decodable element ID. The view will not scroll to it.`
);
}

// Don't reset if this navigation opted out
Expand Down