fix: warn when multiple React Router versions are loaded - #15369
Open
Turtle-Hwan wants to merge 2 commits into
Open
fix: warn when multiple React Router versions are loaded#15369Turtle-Hwan wants to merge 2 commits into
Turtle-Hwan wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15356.
Problem
Loading
react-routerandreact-router-domversions that resolve to differentreact-routermodule instances creates separate React contexts. Hooks canreport a generic missing-router error, while
<Outlet>can render nothingwithout explaining the version mismatch.
Changes
window.__reactRouterVersionmarker to track versionsseen in the browser
<Outlet>path are coveredThe patch intentionally does not attempt to bridge incompatible React contexts.
The warning tells users to align their
react-routerandreact-router-domversions.
Validation
pnpm buildpnpm test packages/react-router/ --runInBandpnpm typecheckpnpm lint— 0 errors; existing warnings onlypnpm changes:validateuseNavigateand<Outlet>