fix(architect): restore x-forwarded-host default handling for lambda servers - #15389
Open
SnowingFox wants to merge 1 commit into
Open
fix(architect): restore x-forwarded-host default handling for lambda servers#15389SnowingFox wants to merge 1 commit into
SnowingFox wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15378.
PR #15188 removed the
useRequestContextDomainNameoption from the@react-router/architectadapter and madeevent.requestContext.domainNamethe sole default when deriving the request host, droppingx-forwarded-hostfrom consideration entirely.For Lambda Function URLs deployed behind CloudFront,
requestContext.domainNameis the internal*.lambda-url...on.awshost while the viewer-facing host is carried in thex-forwarded-hostheader populated by CloudFront. Becauserequest.urlwas now built with the Lambda URL host, React Router's single-fetchthrowIfPotentialCSRFAttackcheck compared the browserOrigin(https://...cloudfront.net) against the Lambda URL and rejected legitimate same-origin browser POSTs.This restores
x-forwarded-hostas the priority candidate when constructing the request URL, falling back torequestContext.domainNameand then theHostheader. That matches the pre-#15188 default behavior for proxied deployments while still preferring the request-context domain name when no proxy header is present.