fix(dom): decode pathname in NavLink active comparison - #15405
Open
ErfanBagheri404 wants to merge 1 commit into
Open
fix(dom): decode pathname in NavLink active comparison#15405ErfanBagheri404 wants to merge 1 commit into
ErfanBagheri404 wants to merge 1 commit into
Conversation
Encode a Location the same way window.location would. The browser's location.pathname does not encode special characters like pipe (|), but navigator.encodeLocation (via new URL) percent-encodes them to %7C. This caused NavLink to always report as inactive when using these characters in dynamic segments. Decode both sides with the existing decodePath helper before comparing, so the comparison works consistently regardless of the encoding path. Fixes remix-run#10781
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10781
navigator.encodeLocationpercent-encodes special characters (e.g.|?%7C) vianew URL(), butlocation.pathnamefrom the browser keeps them raw. This causedNavLinkto never match when dynamic segments contained characters like|.Decode both sides with the existing
decodePathhelper before comparing so the active-state check is encoding-consistent. Added a regression test for the pipe character.Also related to #14619.