fix(dev): let SPA Vite builds exit after prerendering - #15429
Open
Fnine59 wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
A direct
vite buildin SPA mode completed its output but kept running because the internal prerender preview closed its HTTP server without closing the React Router plugin resources created while resolving the preview config.Wrap the preview server's idempotent
close()method so callers also await cleanup of the plugin's child compiler, config loader, and typegen watcher. Normal watcher behavior while a preview server is running is unchanged.Tests
Added a focused SPA integration regression that invokes the Vite CLI directly and requires it to exit naturally after prerendering instead of using the React Router CLI's explicit process exit.
Fixes #15427