feat: add hover docs for use-chain injected functions with @callback fallback#20
Open
aayushmau5 wants to merge 1 commit intoremoteoss:mainfrom
Open
feat: add hover docs for use-chain injected functions with @callback fallback#20aayushmau5 wants to merge 1 commit intoremoteoss:mainfrom
@callback fallback#20aayushmau5 wants to merge 1 commit intoremoteoss:mainfrom
Conversation
aayushmau5
changed the title
@callback fallback@callback fallback
Collaborator
|
Thanks for the contribution @aayushmau5, I haven't yet looked at the code, but this is a great contribution and I think a great idea! Will take a closer look tomorrow. |
Collaborator
|
@aayushmau5 I noticed that the PR is still in draft, is this intentional? |
Author
|
Nope. Now up for review :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A PoC change that adds support for showing hover docs for use-chain injected function which holds their documentation in callbacks.
For example, Ecto's Repo
usemacro don't hold the documentation. They are actually present in the callbacks.Screen.Recording.2026-04-13.at.12.03.41.AM.mov