[DO NOT LAND] Allow us to disable namespace listwatching #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The namespaces cache will be an empty store in this case. Down the line all of the code _should_ just work for instance emitting an error log if you try to access namespace labels.
|
excited to see what this will do in staging |
|
@imbstack I think I never got that far. I ultimately got pulled in another direction and never finished my patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The namespaces cache will be an empty store in this case. Down the line all of the code should just work (it appears to check for missing namepaces, etc) for instance emitting an error log if you try to access namespace labels.
Don't land this yet. I still want to add tests, etc. Maybe we can try this on staging though. @mdbenjam were you able to use an image you built on your local machine when you were patching vector before?
Relates to renderinc/api#23296