feat(config): filePatterns #34615

RahulGautamSingh · 2025-03-04T17:35:47Z

Changes

Migrate fileMatch to filePatterns
Add glob pattern support

Context

Closes: Migrate fileMatch to filePatterns and support matchRegexOrGlobList #34427

Documentation (please check one with an [x])

I have updated the documentation, or
No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

Code inspection only, or
Newly added/modified unit tests, or
No unit tests but ran on a real repository, or
Both unit tests + ran on a real repository 1. https://github.com/Rahul-renovate-testing/renovate/pulls 2. Update ghcr.io/containerbase/sidecar Docker tag to v13.8.4 Rahul-renovate-testing/repro-34427#1

docs/usage/docker.md

lib/config/migration.spec.ts

lib/config/migrations/custom/file-match-migration.ts

Co-authored-by: Sebastian Poxhofer <[email protected]>

docs/usage/configuration-options.md

docs/usage/user-stories/maintaining-aur-packages-with-renovate.md

lib/modules/manager/helm-values/readme.md

lib/modules/manager/helmsman/readme.md

lib/modules/manager/html/readme.md

Co-authored-by: HonkingGoose <[email protected]>

docs/usage/configuration-options.md

docs/usage/getting-started/private-packages.md

lib/config/validation.ts

lib/modules/datasource/aws-rds/readme.md

Co-authored-by: Michael Kriese <[email protected]>

viceice

there are some more samples, which can be simplified by using glob, otherwise LGTM

docs/usage/configuration-options.md

Co-authored-by: Michael Kriese <[email protected]>

viceice

we can do the regex to glob changes in a followup pr of cause

tools/docs/manager.ts

lib/modules/manager/terragrunt/index.ts

viceice · 2025-03-06T18:48:12Z

needs update because of:

feat: new manager pixi #34400

lib/modules/manager/terragrunt/index.ts

rarkins

Partial review done. Please note each of the suggested changes and apply them widely to the whole PR. e.g. ^foo$ patterns should always just be foo.

docs/usage/configuration-options.md

docs/usage/user-stories/maintaining-aur-packages-with-renovate.md

rarkins · 2025-03-07T21:37:54Z

lib/config/presets/internal/custom-managers.ts

@@ -78,7 +78,7 @@ export const presets: Record<string, Preset> = {
      {
        customType: 'regex',
        datasourceTemplate: 'docker',
-        fileMatch: ['(^|/)Chart\\.yaml$'],
+        filePatterns: ['/(^|/)Chart\\.yaml$/'],


Suggested change

filePatterns: ['/(^|/)Chart\\.yaml$/'],

filePatterns: ['**/Chart.yaml'],

why resolved?

lib/config/presets/internal/custom-managers.ts

lib/modules/datasource/aws-machine-image/readme.md

lib/modules/datasource/aws-rds/readme.md

docs/usage/configuration-options.md

viceice · 2025-03-09T12:34:39Z

docs/usage/configuration-options.md

@@ -792,7 +792,7 @@ Example:
  "customManagers": [
    {
      "customType": "regex",
-      "fileMatch": ["values.yaml$"],
+      "filePatterns": ["**values.yaml"],


Suggested change

"filePatterns": ["**values.yaml"],

"filePatterns": ["**/values.yaml"],

viceice · 2025-03-09T12:35:20Z

docs/usage/configuration-options.md

@@ -884,7 +884,7 @@ Only the `json`, `toml` and `yaml` formats are supported.
    {
      "customType": "jsonata",
      "fileFormat": "toml",
-      "fileMatch": ["file.toml"],
+      "filePatterns": ["some/file.toml"],


is this path change intentional?

viceice · 2025-03-09T12:38:12Z

docs/usage/modules/manager/index.md


 ```json
 {
  "kubernetes": {
-    "fileMatch": ["^config/.*\\.yaml$"]
+    "filePatterns": ["/^config/.*\\.yaml$/"]


Suggested change

"filePatterns": ["/^config/.*\\.yaml$/"]

"filePatterns": ["config/**/*.yaml"]

looks simpler

viceice · 2025-03-09T12:40:34Z

lib/config/presets/internal/custom-managers.ts

@@ -78,7 +78,7 @@ export const presets: Record<string, Preset> = {
      {
        customType: 'regex',
        datasourceTemplate: 'docker',
-        fileMatch: ['(^|/)Chart\\.yaml$'],
+        filePatterns: ['/(^|/)Chart\\.yaml$/'],


why resolved?

viceice · 2025-03-09T12:41:20Z

lib/config/presets/internal/custom-managers.ts

-          '(^|/)GNUMakefile$',
-          '\\.mk$',
-        ],
+        filePatterns: ['**/Makefile', '**/GNUMakefile', '**/*.mk'],


are you sure glob is case insensitive?

Suggested change

filePatterns: ['**/Makefile', '**/GNUMakefile', '**/*.mk'],

filePatterns: ['**/{M,m}akefile', '**/GNUMakefile', '**/*.mk'],

Rhys, suggested that it is case insensitive. I didn't double check and went with the suggestion.

I looked it up and there seems to be mixed answers. I will apply your suggestion to be 100% safe.

viceice · 2025-03-09T12:41:52Z

lib/config/presets/internal/custom-managers.ts

@@ -109,7 +104,7 @@ export const presets: Record<string, Preset> = {
        customType: 'regex',
        datasourceTemplate:
          '{{#if datasource}}{{{datasource}}}{{else}}maven{{/if}}',
-        fileMatch: ['(^|/)pom\\.xml$'],
+        filePatterns: ['/(^|/)pom\\.xml$/'],


Suggested change

filePatterns: ['/(^|/)pom\\.xml$/'],

filePatterns: ['**/pom.xml'],

viceice · 2025-03-09T12:42:39Z

lib/config/presets/internal/custom-managers.ts

@@ -122,7 +117,7 @@ export const presets: Record<string, Preset> = {
    customManagers: [
      {
        customType: 'regex',
-        fileMatch: ['.+\\.tfvars$'],
+        filePatterns: ['/.+\\.tfvars$/'],


Suggested change

filePatterns: ['/.+\\.tfvars$/'],

filePatterns: ['**/*.tfvars'],

simplify others too where possible

viceice · 2025-03-09T12:43:48Z

lib/modules/datasource/aws-rds/readme.md

@@ -91,7 +91,7 @@ Here is the Renovate configuration to use Terraform, `aws-rds` and Aurora MySQL:
    {
      "description": "Update RDS",
      "customType": "regex",
-      "fileMatch": [".+\\.tf$"],
+      "filePatterns": ["/.+\\.tf$/"],


Suggested change

"filePatterns": ["/.+\\.tf$/"],

"filePatterns": ["**/*.tf"],

prefer glob in samples where possible

Co-authored-by: Michael Kriese <[email protected]>

secustor · 2025-03-09T20:19:05Z

lib/modules/manager/fleet/readme.md


 ```json
 {
-  "fileMatch": ["'(^|/)fleet.ya?ml", "myGitRepoManifests\\.yaml"]
+  "filePatterns": ["**/fleet.{yaml,yml}", "**myGitRepoManifests.yaml"]


Suggested change

"filePatterns": ["**/fleet.{yaml,yml}", "**myGitRepoManifests.yaml"]

"filePatterns": ["**/fleet.{yaml,yml}", "**/myGitRepoManifests.yaml"]

secustor · 2025-03-09T20:19:28Z

lib/modules/manager/pip-compile/readme.md


 ```json
 {
  "pip-compile": {
-    "fileMatch": ["(^|/)requirements\\.txt$"]
+    "filePatterns": ["**/requirements\\.txt"]


Suggested change

"filePatterns": ["**/requirements\\.txt"]

"filePatterns": ["**/requirements.txt"]

secustor · 2025-03-09T20:20:51Z

lib/modules/manager/pixi/index.ts

+    '/(^|/)pyproject\\.toml$/', // `tool.pixi` section
+    '/(^|/)pixi\\.toml$/', // root object


Suggested change

'/(^|/)pyproject\\.toml$/', // `tool.pixi` section

'/(^|/)pixi\\.toml$/', // root object

'**/pyproject.toml', // `tool.pixi` section

'**/pixi.toml', // root object

secustor · 2025-03-09T20:21:17Z

lib/modules/manager/puppet/index.ts

@@ -9,7 +9,7 @@ export const url = 'https://www.puppet.com/docs/index.html';
 export const categories: Category[] = ['iac', 'ruby'];

 export const defaultConfig = {
-  fileMatch: ['(^|/)Puppetfile$'],
+  filePatterns: ['/(^|/)Puppetfile$/'],


Suggested change

filePatterns: ['/(^|/)Puppetfile$/'],

filePatterns: ['**/Puppetfile'],

secustor · 2025-03-09T20:22:55Z

lib/modules/manager/pyenv/index.ts

@@ -9,7 +9,7 @@ export const url = 'https://github.com/pyenv/pyenv#readme';
 export const categories: Category[] = ['python'];

 export const defaultConfig = {
-  fileMatch: ['(^|/)\\.python-version$'],
+  filePatterns: ['/(^|/)\\.python-version$/'],


Suggested change

filePatterns: ['/(^|/)\\.python-version$/'],

filePatterns: ['**/.python-version'],

secustor · 2025-03-09T21:04:29Z

lib/modules/manager/cake/index.ts

@@ -8,7 +8,7 @@ export const url = 'https://cakebuild.net/docs';
 export const categories: Category[] = ['dotnet'];

 export const defaultConfig = {
-  fileMatch: ['\\.cake$'],
+  filePatterns: ['/\\.cake$/'],


Suggested change

filePatterns: ['/\\.cake$/'],

filePatterns: ['**/*.cake'],

secustor · 2025-03-09T21:04:56Z

lib/modules/manager/cargo/index.ts

@@ -16,7 +16,7 @@ export const categories: Category[] = ['rust'];

 export const defaultConfig = {
  commitMessageTopic: 'Rust crate {{depName}}',
-  fileMatch: ['(^|/)Cargo\\.toml$'],
+  filePatterns: ['/(^|/)Cargo\\.toml$/'],


Suggested change

filePatterns: ['/(^|/)Cargo\\.toml$/'],

filePatterns: ['**/Cargo.toml'],

secustor · 2025-03-09T21:05:57Z

lib/modules/manager/cocoapods/index.ts

@@ -13,7 +13,7 @@ export const url = 'https://cocoapods.org';
 export const categories: Category[] = ['swift'];

 export const defaultConfig = {
-  fileMatch: ['(^|/)Podfile$'],
+  filePatterns: ['/(^|/)Podfile$/'],


Suggested change

filePatterns: ['/(^|/)Podfile$/'],

filePatterns: ['**/Podfile'],

secustor · 2025-03-09T21:06:42Z

lib/modules/manager/cpanfile/index.ts

@@ -10,7 +10,7 @@ export const url =
 export const categories: Category[] = ['perl'];

 export const defaultConfig = {
-  fileMatch: ['(^|/)cpanfile$'],
+  filePatterns: ['/(^|/)cpanfile$/'],


Suggested change

filePatterns: ['/(^|/)cpanfile$/'],

filePatterns: ['**/cpanfile'],

secustor · 2025-03-09T21:07:35Z

lib/modules/manager/devbox/index.ts

@@ -6,7 +6,7 @@ export { updateArtifacts } from './artifacts';
 export const supportsLockFileMaintenance = true;

 export const defaultConfig = {
-  fileMatch: ['(^|/)devbox\\.json$'],
+  filePatterns: ['/(^|/)devbox\\.json$/'],


Suggested change

filePatterns: ['/(^|/)devbox\\.json$/'],

filePatterns: ['**/devbox.json'],

RahulGautamSingh added 4 commits March 4, 2025 22:12

add glob support to fileMatch

97bd988

migration: fileMatch -> filePatterns

b37cafe

docs: fileMatch -> filePatterns

ece0ccb

more replacements

7311a6d

RahulGautamSingh requested review from rarkins, HonkingGoose, viceice and secustor March 4, 2025 18:01

secustor reviewed Mar 4, 2025

View reviewed changes

docs/usage/docker.md Outdated Show resolved Hide resolved

lib/config/migration.spec.ts Outdated Show resolved Hide resolved

lib/config/migrations/custom/file-match-migration.ts Outdated Show resolved Hide resolved

Apply suggestions from code review

db189af

Co-authored-by: Sebastian Poxhofer <[email protected]>

RahulGautamSingh requested a review from secustor March 4, 2025 18:29

HonkingGoose suggested changes Mar 5, 2025

View reviewed changes

Apply suggestions from code review

d676c79

Co-authored-by: HonkingGoose <[email protected]>

RahulGautamSingh requested a review from HonkingGoose March 5, 2025 16:07

viceice mentioned this pull request Mar 5, 2025

feat: add generic bumpVersions option #34023

Open

6 tasks

viceice reviewed Mar 5, 2025

View reviewed changes

docs/usage/configuration-options.md Outdated Show resolved Hide resolved

docs/usage/getting-started/private-packages.md Outdated Show resolved Hide resolved

lib/config/validation.ts Show resolved Hide resolved

lib/modules/datasource/aws-rds/readme.md Outdated Show resolved Hide resolved

Apply suggestions from code review

04e8987

Co-authored-by: Michael Kriese <[email protected]>

secustor previously approved these changes Mar 5, 2025

View reviewed changes

RahulGautamSingh requested a review from viceice March 5, 2025 20:54

viceice reviewed Mar 6, 2025

View reviewed changes

docs/usage/configuration-options.md Outdated Show resolved Hide resolved

Update docs/usage/configuration-options.md

e9938fc

Co-authored-by: Michael Kriese <[email protected]>

RahulGautamSingh dismissed secustor’s stale review via e9938fc March 6, 2025 09:53

RahulGautamSingh requested review from viceice and secustor March 6, 2025 12:34

viceice reviewed Mar 6, 2025

View reviewed changes

tools/docs/manager.ts Outdated Show resolved Hide resolved

tools/docs/manager.ts Outdated Show resolved Hide resolved

lib/modules/manager/terragrunt/index.ts Outdated Show resolved Hide resolved

viceice and others added 2 commits March 6, 2025 19:48

Merge branch 'main' into feat-34427

cb6f15d

apply suggestions

8f3d79a

RahulGautamSingh requested review from viceice March 7, 2025 11:32

trim21 reviewed Mar 7, 2025

View reviewed changes

lib/modules/manager/terragrunt/index.ts Outdated Show resolved Hide resolved

rarkins requested changes Mar 7, 2025

View reviewed changes

apply suggestions

a80a49f

RahulGautamSingh requested review from trim21 and rarkins March 8, 2025 06:14

viceice reviewed Mar 9, 2025

View reviewed changes

Update configuration-options.md

c3504d5

Co-authored-by: Michael Kriese <[email protected]>

secustor reviewed Mar 9, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(config): filePatterns #34615

feat(config): filePatterns #34615

RahulGautamSingh commented Mar 4, 2025 •

edited

Loading

viceice left a comment

viceice left a comment

viceice commented Mar 6, 2025

rarkins left a comment

rarkins Mar 7, 2025

viceice Mar 9, 2025

viceice Mar 9, 2025

viceice Mar 9, 2025

viceice Mar 9, 2025

viceice Mar 9, 2025

viceice Mar 9, 2025

RahulGautamSingh Mar 10, 2025

viceice Mar 9, 2025

viceice Mar 9, 2025

viceice Mar 9, 2025

secustor Mar 9, 2025

secustor Mar 9, 2025

secustor Mar 9, 2025

secustor Mar 9, 2025

secustor Mar 9, 2025

secustor Mar 9, 2025

secustor Mar 9, 2025

secustor Mar 9, 2025

secustor Mar 9, 2025

secustor Mar 9, 2025

	filePatterns: ['/(^\|/)Chart\\.yaml$/'],
	filePatterns: ['**/Chart.yaml'],

	"filePatterns": ["**values.yaml"],
	"filePatterns": ["**/values.yaml"],

	"filePatterns": ["/^config/.*\\.yaml$/"]
	"filePatterns": ["config/*/.yaml"]

	filePatterns: ['/Makefile', '/GNUMakefile', '*/.mk'],
	filePatterns: ['/{M,m}akefile', '/GNUMakefile', '*/.mk'],

	filePatterns: ['/(^\|/)pom\\.xml$/'],
	filePatterns: ['**/pom.xml'],

	filePatterns: ['/.+\\.tfvars$/'],
	filePatterns: ['*/.tfvars'],

	"filePatterns": ["/fleet.{yaml,yml}", "myGitRepoManifests.yaml"]
	"filePatterns": ["/fleet.{yaml,yml}", "/myGitRepoManifests.yaml"]

	"filePatterns": ["**/requirements\\.txt"]
	"filePatterns": ["**/requirements.txt"]

		'/(^\|/)pyproject\\.toml$/', // `tool.pixi` section
		'/(^\|/)pixi\\.toml$/', // root object

	filePatterns: ['/(^\|/)Puppetfile$/'],
	filePatterns: ['**/Puppetfile'],

	filePatterns: ['/(^\|/)\\.python-version$/'],
	filePatterns: ['**/.python-version'],

	filePatterns: ['/(^\|/)Cargo\\.toml$/'],
	filePatterns: ['**/Cargo.toml'],

	filePatterns: ['/(^\|/)Podfile$/'],
	filePatterns: ['**/Podfile'],

	filePatterns: ['/(^\|/)cpanfile$/'],
	filePatterns: ['**/cpanfile'],

	filePatterns: ['/(^\|/)devbox\\.json$/'],
	filePatterns: ['**/devbox.json'],

feat(config): filePatterns #34615

Are you sure you want to change the base?

feat(config): filePatterns #34615

Conversation

RahulGautamSingh commented Mar 4, 2025 • edited Loading

Changes

Context

Documentation (please check one with an [x])

How I've tested my work (please select one)

viceice left a comment

Choose a reason for hiding this comment

viceice left a comment

Choose a reason for hiding this comment

viceice commented Mar 6, 2025

rarkins left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RahulGautamSingh commented Mar 4, 2025 •

edited

Loading