Fix dependabot security vulnerabilities#536
Conversation
Updated package versions and added resolutions/overrides for: - tar: 7.5.6 → 7.5.8 (hardlink/symlink path traversal fixes) - qs: 6.14.1 → 6.14.2 (arrayLimit DoS bypass) - hono: 4.11.4 → 4.11.10 (XSS, cache deception, IP spoofing fixes) - @playwright/test: 1.49.1 → 1.55.1 (SSL certificate verification) - Added ajv 8.18.0, lodash 4.17.23, webpack 5.104.1, bn.js 5.2.3, minimatch 10.2.1 Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
|
Claude finished @ignaciosantise's task —— View job PR Review: Fix dependabot security vulnerabilitiesTasks
SummaryThis PR appropriately addresses security vulnerabilities through dependency upgrades and resolution pinning. The changes are low-risk as they only modify dependency versions without touching application logic. However, there are several issues that need to be addressed. Critical Issues1. Inconsistent
|
There was a problem hiding this comment.
Pull request overview
This PR addresses 20 open dependabot security alerts by upgrading vulnerable dependencies to patched versions across the monorepo. The changes include critical security fixes for tar (path traversal vulnerabilities), qs (DoS bypass), hono (XSS and cache deception), and @playwright/test (SSL verification). The PR uses Yarn resolutions in the root package.json and npm overrides in examples/expo-multichain/package.json to enforce patched versions throughout the dependency tree.
Changes:
- Upgraded tar from 7.5.6 to 7.5.8 to fix hardlink/symlink path traversal vulnerabilities
- Upgraded qs from 6.14.1 to 6.14.2 to fix DoS bypass
- Upgraded
@playwright/testfrom 1.49.1 to 1.55.1 to fix SSL verification issues - Upgraded hono from 4.11.4 to 4.11.10 to fix XSS and cache deception vulnerabilities
- Added resolutions/overrides for ajv (8.18.0), lodash (4.17.23), and webpack (5.104.1) to force patched versions across the dependency tree
- Updated yarn.lock and package-lock.json with corresponding changes, including removal of deprecated dependencies (ajv v6, concat-map)
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Added resolutions for tar, qs, ajv, lodash, and webpack to enforce secure versions |
| apps/native/package.json | Upgraded @playwright/test to 1.55.1 for SSL verification fix |
| examples/expo-multichain/package.json | Added overrides for hono, tar, ajv, bn.js, and minimatch |
| yarn.lock | Updated with patched versions, removed ajv v6 and related deprecated dependencies |
| examples/expo-multichain/package-lock.json | Updated with patched versions for hono, tar, ajv, bn.js, and minimatch; removed deprecated brace-expansion v1/v2 and concat-map |
Files not reviewed (1)
- examples/expo-multichain/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "tar": "7.5.6", | ||
| "tar": "7.5.8", | ||
| "node-forge": "1.3.2", | ||
| "qs": "6.14.1", |
There was a problem hiding this comment.
The qs version override is inconsistent with the root package.json. The root package.json has qs upgraded to 6.14.2, but this file still has 6.14.1. For consistency and to ensure the security patch is applied across the monorepo, this should be updated to 6.14.2.
| "resolved": "https://registry.npmjs.org/ajv/-/ajv-8.17.1.tgz", | ||
| "integrity": "sha512-B/gBuNg5SiMTrPkC+A2+cW0RszwxYmn6VYxB/inlBStS5nx6xHIt/ehKRhIMhqusl7a8LjQoZnjCs5vhwxOQ1g==", | ||
| "version": "8.18.0", | ||
| "resolved": "https://registry.npmjs.org/ajv/-/ajv-8.18.0.tgz", |
There was a problem hiding this comment.
External Domain URL Detected
Low Severity
This change introduces URLs pointing to external domains in the lock file (e.g., https://registry.npmjs.org/ajv/-/ajv-8.18.0.tgz, https://github.com/sponsors/epoberezkin). Please verify that these external dependencies are intentional and review for potential security, privacy, or compliance implications. Approved company domains are: reown.com, walletconnect.com, walletconnect.org
Triggered by team rule: External Domain URL Detection
Align qs from 6.14.1 to 6.14.2 in expo-multichain overrides to match root package.json and apply the DoS bypass security fix consistently. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
- Use scoped resolution schema-utils/ajv instead of blanket ajv to avoid breaking @eslint/eslintrc which needs ajv v6 - Remove ajv override from expo-multichain (not applicable there) - Remove qs override from expo-multichain (not a transitive dep) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|





Summary
This PR resolves 20 open dependabot security alerts by upgrading vulnerable dependencies and adding resolutions/overrides to force patched versions across the monorepo. Updates include critical patches for tar (hardlink/symlink path traversal), qs (DoS bypass), hono (XSS, cache deception), and @playwright/test (SSL verification). Dependencies like ajv, lodash, webpack, bn.js, and minimatch have been added to resolution/override configurations. The bigint-buffer vulnerability remains unpatched upstream with no available fix.
Changes
Note
Medium Risk
Primarily dependency/lockfile churn, but upgrades to build tooling (
webpack) and security-sensitive libraries (tar,qs,hono) could introduce subtle compatibility changes at runtime or in CI.Overview
Security-focused dependency refresh across the monorepo. Updates include bumping
@playwright/test(native app), and pinning/upgrading vulnerable transitive deps via rootresolutionsand example appoverrides(notablytar,qs,hono, plusajv,lodash,webpack,bn.js,minimatch).Lockfiles are regenerated (
yarn.lock,examples/expo-multichain/package-lock.json) to reflect the patched versions and tightened dependency graph.Written by Cursor Bugbot for commit 54ff4b9. This will update automatically on new commits. Configure here.