-
Notifications
You must be signed in to change notification settings - Fork 1.6k
chore: update demo to 1.8.13 #5315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
10 Skipped Deployments
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the @reown/appkit package ecosystem from version 1.8.8 to 1.8.13, along with updating related dependency versions in the lockfile. The changes include updates to core appkit packages, adapters, and testing utilities.
Key Changes
- Updated all
@reown/appkit*packages from1.8.8to1.8.13 - Updated
zodpeer dependency from3.25.76to4.1.12across multiple packages - Added
use-sync-external-storeas a peer dependency for ethers adapter - Updated various
@walletconnectdependencies to newer versions
Reviewed Changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pnpm-lock.yaml | Updated package versions and dependency resolutions for the appkit ecosystem and related dependencies |
| apps/demo/package.json | Updated @reown/appkit* package versions from 1.8.8 to 1.8.13 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Visual Regression Test Results ✅ Passed✨ No visual changes detected Chromatic Build: https://www.chromatic.com/build?appId=6493191bf4b10fed8ca7353f&number=296 |
📦 Bundle Size Check✅ All bundles are within size limits 📊 View detailed bundle sizes> @reown/[email protected] size /home/runner/work/appkit/appkit > size-limit |
Coverage Report
File CoverageNo changed files found. |
| specifier: 1.8.8 | ||
| version: 1.8.8(@types/[email protected])([email protected])([email protected])([email protected])([email protected])([email protected])([email protected])([email protected])(zod@3.25.76) | ||
| specifier: 1.8.13 | ||
| version: 1.8.13(@types/[email protected])([email protected])([email protected])([email protected])([email protected])([email protected])([email protected])([email protected])(zod@4.1.12) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Zod Version Mismatch Causes Compatibility Breakages
Major version mismatch in zod dependency. The demo app's @reown/appkit packages (1.8.13) are resolving to [email protected], but the workspace packages they depend on (like @reown/appkit-wallet and @reown/appkit-experimental) explicitly require [email protected]. This major version upgrade from zod v3 to v4 introduces breaking changes and could cause runtime errors, type incompatibilities, or validation failures. The demo app should use the same zod version (3.22.4 or 3.25.76) as the underlying @Reown packages to ensure compatibility.
Description
Type of change
Note
Updates the demo to
@reown/appkit1.8.13 and refreshes the lockfile with related dependency updates (WalletConnect, Solana, zod, etc.).apps/demo/package.json):@reown/appkitsuite to1.8.13(appkit,-adapter-bitcoin,-adapter-ethers,-adapter-solana,-common,-controllers,-scaffold-ui,-ui).@reown/appkit-testingto1.8.13.pnpm-lock.yaml) updates:[email protected], including[email protected]adoption across packages.2.22.xvariants (core, utils, universal-provider, sign-client) and logger3.xwhere applicable.@solana/spl-token0.4.14, optional@base-org/account,@wagmi/connectors).Written by Cursor Bugbot for commit 89e6d7b. This will update automatically on new commits. Configure here.