Skip to content

Conversation

@enesozturk
Copy link
Contributor

@enesozturk enesozturk commented Nov 5, 2025

Description

Await swap tokens response at least 10 secs on e2e flows

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Note

Add explicit waits for swap token items before clicking and increase account button attach timeout to 3s.

  • Tests (Playwright):
    • Swap flow: Wait for swap-select-token-item-ETH and swap-select-token-item-USDC to be visible (10s) before clicking.
    • Connection: Increase appkit-account-button attach timeout in expectToBeConnectedInstantly to 3_000 ms.

Written by Cursor Bugbot for commit 60c1373. This will update automatically on new commits. Configure here.

@changeset-bot
Copy link

changeset-bot bot commented Nov 5, 2025

⚠️ No Changeset found

Latest commit: 60c1373

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 5, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
appkit-basic-html Ready Ready Preview Comment Nov 6, 2025 8:33am
appkit-demo Ready Ready Preview Comment Nov 6, 2025 8:33am
appkit-gallery Ready Ready Preview Comment Nov 6, 2025 8:33am
appkit-laboratory Ready Ready Preview Comment Nov 6, 2025 8:33am
10 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
appkit-basic-example Ignored Ignored Nov 6, 2025 8:33am
appkit-basic-sign-client-example Ignored Ignored Nov 6, 2025 8:33am
appkit-basic-up-example Ignored Ignored Nov 6, 2025 8:33am
appkit-ethers5-bera Ignored Ignored Nov 6, 2025 8:33am
appkit-nansen-demo Ignored Ignored Nov 6, 2025 8:33am
appkit-vue-solana Ignored Ignored Nov 6, 2025 8:33am
appkit-wagmi-cdn-example Ignored Ignored Nov 6, 2025 8:33am
ethereum-provider-wagmi-example Ignored Ignored Nov 6, 2025 8:33am
next-wagmi-solana-bitcoin-example Ignored Ignored Nov 6, 2025 8:33am
vue-wagmi-example Ignored Ignored Nov 6, 2025 8:33am

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

Visual Regression Test Results ✅ Passed

✨ No visual changes detected

Chromatic Build: https://www.chromatic.com/build?appId=6493191bf4b10fed8ca7353f&number=318
Storybook Preview: https://6493191bf4b10fed8ca7353f-xztvynkebs.chromatic.com/

@enesozturk enesozturk requested a review from a team November 5, 2025 15:40
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

📦 Bundle Size Check

All bundles are within size limits

📊 View detailed bundle sizes

> @reown/[email protected] size /home/runner/work/appkit/appkit


> size-limit

@reown/appkit - Main Entry
Size limit:   80 kB
Size:         70.59 kB with all dependencies, minified and gzipped
Loading time: 1.4 s    on slow 3G
Running time: 400 ms   on Snapdragon 410
Total time:   1.8 s
@reown/appkit/react
Size limit:   230 kB
Size:         227.18 kB with all dependencies, minified and gzipped
Loading time: 4.5 s     on slow 3G
Running time: 647 ms    on Snapdragon 410
Total time:   5.1 s
@reown/appkit/vue
Size limit:   80 kB
Size:         70.59 kB with all dependencies, minified and gzipped
Loading time: 1.4 s    on slow 3G
Running time: 414 ms   on Snapdragon 410
Total time:   1.8 s
@reown/appkit-scaffold-ui
Size limit:   220 kB
Size:         207.22 kB with all dependencies, minified and gzipped
Loading time: 4.1 s     on slow 3G
Running time: 496 ms    on Snapdragon 410
Total time:   4.6 s
@reown/appkit-ui
Size limit:   500 kB
Size:         13.15 kB with all dependencies, minified and gzipped
Loading time: 257 ms   on slow 3G
Running time: 114 ms   on Snapdragon 410
Total time:   370 ms

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 79.9% 38046 / 47616
🔵 Statements 79.9% 38046 / 47616
🔵 Functions 77.95% 4110 / 5272
🔵 Branches 86.47% 9220 / 10662
File CoverageNo changed files found.
Generated in workflow #16225 for commit 60c1373 by the Vitest Coverage Report Action

@enesozturk enesozturk added this pull request to the merge queue Nov 6, 2025
@enesozturk enesozturk removed this pull request from the merge queue due to a manual request Nov 6, 2025
@enesozturk enesozturk deleted the chore/swap-api-await-on-e2e branch November 6, 2025 09:54
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants