Skip to content

Assert access checks #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Assert access checks #260

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e76fb59
Assert access checks
Domiii Jun 27, 2024
31407bb
Merge branch 'master' of https://github.com/replayio/chromium-v8 into…
Domiii Jul 9, 2024
4902428
Undo Asserts, but add `REPLAY_ASSERT_IF`
Domiii Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions include/replayio-macros.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@
recordreplay::Assert(format, ##__VA_ARGS__); \
static_assert(true, "require semicolon")

// Same as |REPLAY_ASSERT| but won't Assert if the given condition is not true.
#define REPLAY_ASSERT_IF(cond, format, ...) \
Copy link

@toshok toshok Jul 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these be defined in terms of one another?

e.g. REPLAY_ASSERT_IF could be:

#define REPLAY_ASSERT_IF(cond, format, ...) \
  if (cond) REPLAY_ASSERT(format, ##__VA_ARGS__)

and REPLAY_ASSERT_MAYBE_EVENTS_DISALLOWED could be:

#define REPLAY_ASSERT_MAYBE_EVENTS_DISALLOWED(format, ...) \
  REPLAY_ASSERT_IF(!recordreplay::AreEventsDisallowed(), format, ##__VA_ARGS__);

or REPLAY_ASSERT_IF could be the one that's ultimately evaluated with REPLAY_ASSERT being defined as:

#define REPLAY_ASSERT(format, ...) \
  REPLAY_ASSERT_IF(true, format, ## __VA_ARGS__)

otherwise I'd be concerned about things diverging between the macros.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. ❌Your first suggestion is a no-go, because suddenly you are evaluating cond even when things are enabled.
  2. 🤷‍♀️ I don't like the unnecessary if (true) in your third suggestion.
  3. ✅ I'm not concerned at all, since this is is going to be a very small set of often-used macros.

if (recordreplay::HasAsserts() && (cond)) \
recordreplay::Assert(format, ##__VA_ARGS__); \
static_assert(true, "require semicolon")

// Same as |REPLAY_ASSERT| but won't Assert when Events are disallowed.
#define REPLAY_ASSERT_MAYBE_EVENTS_DISALLOWED(format, ...) \
if (recordreplay::HasAsserts() && !recordreplay::AreEventsDisallowed()) \
Expand Down