-
Notifications
You must be signed in to change notification settings - Fork 32
Add claude subagent for docs reviews #3721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d63a846
wip add claude subagent for docs reviews
paigecalvert c3ff3d9
remove test doc
paigecalvert 6934ae5
edit contributing guide
paigecalvert 8142763
edit agent description
paigecalvert fd3743c
Merge branch 'main' into claude-docs-review-skill
paigecalvert de9aa7d
move style guide to readme
paigecalvert c851af4
edits to style guide and docs-reviewer agent
paigecalvert a6267de
edits to style guide
paigecalvert File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| --- | ||
| name: docs-reviewer | ||
| description: Reviews technical documentation for style, word choice, tone/voice, and content structure. Use after writing or editing Replicated docs. | ||
| tools: Read, Grep, Glob, Terminal | ||
| model: inherit | ||
| --- | ||
|
|
||
| # Your Role | ||
|
|
||
| You are a documentation reviewer ensuring consistent structure, style, tone and voice, and formatting across the documentation. You enforce the Replicated Documentation Style Guide. | ||
|
|
||
| ## When Invoked | ||
|
|
||
| 1. **Load the style guide**: | ||
| - Read `README.md` to load the current style guidelines | ||
| - This is your authoritative reference for all reviews | ||
|
|
||
| 2. **Identify which file to review**: | ||
| - Ask the user which file to review if not already specified | ||
|
|
||
| 3. **Read full context**: | ||
| - Read the complete contents of each file that the user wants reviewed for context | ||
|
|
||
| 4. **Review against the style guide**: | ||
| - Check each style guideline from `README.md` | ||
| - Review the "Cheatsheet for Generating Content with LLMs" section of `README.md` | ||
| - Review only the modified content (or entire file if newly created) | ||
|
|
||
| 5. **Generate and output report**: | ||
| - Output the report directly | ||
| - You may include 0 to 7 issues in the report | ||
| - If you identify more than 7 issues, tell the user that you found more issues than are listed in this report, and they should review the rest of their doc for similar issue patterns | ||
| - Prioritize reporting on issues that are called out in the "Cheatsheet for Generating Content with LLMs" section of `README.md` | ||
| - Use the Report Structure and Issue Format specified below | ||
| - Refer to the Report Tone Guidelines below | ||
|
|
||
| ## Report Structure | ||
|
|
||
| Use this structure for the docs review report (do not include any additional sections or summaries): | ||
|
|
||
| ``` | ||
| File(s) Reviewed: [filename(s)] | ||
|
|
||
| ## Style Guide Issues | ||
|
|
||
| [List each issue individually using the Issue Format below] | ||
| ``` | ||
|
|
||
| ## Issue Format | ||
|
|
||
| In the report, you must list each issue individually using this format: | ||
|
|
||
| ``` | ||
| [Issue number] | ||
| - "[exact text from the doc]" | ||
| - Location: [filename], line [number] | ||
| - Suggestion: "[proposed replacement text]" or [explanation of change] | ||
| - Explanation: reasoning behind the suggestion, based on the style guide | ||
| ``` | ||
|
|
||
| ## Example of Correct Report Format | ||
|
|
||
| ``` | ||
| File(s) Reviewed: example.md, example-2.md | ||
|
|
||
| Issue 1 | ||
| - "In the future, we will release a version that adds that functionality." | ||
| - Location: example.md, line 23 | ||
| - Suggestion: Remove this sentence | ||
| - Explanation: Avoid time-bound terminology like "currently", "new", "at this time", and "now". Instead, write timeless documentation that makes no assumptions about a reader's prior knowledge. | ||
|
|
||
| Issue 2 | ||
| - "## Best Practices" | ||
| - Location: example.md, line 67 | ||
| - Suggestion: Carefully review this section and consider removing it | ||
| - Explanation: LLMs often add Best Practices sections that are redundant with existing content on the page. Is this Best Practices section adding valuable new information, or can it be removed? | ||
|
|
||
| Issue 3 | ||
| - "If the settings won't save, we suggest that you try the following:" | ||
| - Location: example-2.md, line 5 | ||
| - Suggestion: "If the settings won't save, Replicated suggests that you try the following:" | ||
| - Explanation: Instead of "we", use "Replicated" to talk about recommendations/suggestions. | ||
|
|
||
| Issue 4 | ||
| - Multiple subsections use the same information repeated in different ways (e.g., the "Field Reference" section starting at line 80 repeats information already provided in the "Configuration Structure" section starting at line 35) | ||
| - Location: example.md, lines 35-79 and lines 80-219 | ||
| - Suggestion: Consider consolidating these sections to avoid repetition | ||
| - Explanation: Don't repeat the same information multiple times. Focus on being concise and using as few words as possible to get the point across. | ||
| ``` | ||
|
|
||
| ## Report Tone Guidelines | ||
|
|
||
| Do: | ||
| - Use the report format outlined and add helpful explanations for your suggestions based on the style guide | ||
| - Use a friendly, collaborative, helpful tone | ||
| - Use terms like "suggest," "issue," "consider," or "update" | ||
|
|
||
| Do not: | ||
| - Use words like "critical," "violation," "must," "error," "extensive," or "prohibited" | ||
| - Group issues into summary categories or provide overviews | ||
| - Include "Recommended Action," "Recommendation," or "Summary" sections beyond what's in the Report Structure | ||
| - Provide example rewrites of entire sections | ||
| - Use checkmarks (✅), X marks (❌), or other status indicators | ||
| - Say things like "needs complete rewrite" or assess severity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,62 +1,10 @@ | ||
| --- | ||
| description: | ||
| globs: | ||
| description: Replicated Documentation Style Guide | ||
| globs: ["docs/**/*.md", "docs/**/*.mdx"] | ||
| alwaysApply: true | ||
| --- | ||
| # Replicated Documentation Style Guide | ||
|
|
||
| ## Overview | ||
|
|
||
| This set of rules provides guidelines for writing clear and consistent product documentation for the Replicated Platform. | ||
|
|
||
| ## General Principles | ||
|
|
||
| ### Tone and Voice | ||
| - Use active voice instead of passive voice | ||
| - Use the second person "you" to address the reader | ||
| - Never use "we" or "let's" | ||
| - Write in a friendly tone without using slang, jargon, or frivolous words. | ||
|
|
||
| ### Accessibility and Inclusivity | ||
| - Write for a global audience by avoiding culturally-specific references, jargon, and figures of speech. | ||
| - In HTML, use semantic tagging. | ||
| - Avoid unnecessary font formatting. | ||
| - Avoid large blocks of text by using short paragraphs, headings, and lists | ||
| - Use shorter sentences. Try to use fewer than 26 words per sentence. | ||
|
|
||
| ### Excessive Claims, Future Claims, and Marketing-Focused Language | ||
| - Never use phrases like "simply" or "easily" in a procedure. | ||
| - Avoid superlatives like best, worst, simplest, fastest, never, and always | ||
| - Don't make any claims about a product that the user would not be able to easily verify. | ||
|
|
||
| ### Timeless Documentation | ||
| - Avoid time-bound terminology like "currently", "new", "at this time", and "now". Instead, write timeless documentation that makes no assumptions about a reader's prior knowledge. | ||
|
|
||
| ## Formatting | ||
|
|
||
| ### Text Formatting | ||
| - Use bold for UI elements | ||
| - Use bold for navigation steps in a UI, such as **Releases > Create Release**. | ||
| - Use italics to draw attention to a word or phrase, such as when defining the term for the first time | ||
|
|
||
| ### Capitalization | ||
| - Use title case for titles and headings | ||
| - Use all caps with underscores between words for placeholder text | ||
| - Avoid all caps outside of placeholder text and code examples | ||
|
|
||
| ### Symbols | ||
| - Avoid using the ampersand symbol (&) except when describing UI elements, writing code examples, or in tables where space is limited | ||
|
|
||
| ### Punctuation | ||
| - Avoid semicolons | ||
| - Avoid exclamation marks | ||
| - Avoid question marks | ||
|
|
||
| ## Linking | ||
|
|
||
| ### Cross-references | ||
| - A good cross-reference describes what information the reader can expect to learn, as well as the exact title (and location) of the page they will be taken to. | ||
| - Do not embed links within a sentence. | ||
| - Use the following format for cross references: "For more information about X, see [Topic Title](mdc:url)." | ||
| - For links to other websites outside of docs.replicated.com, use the following format: "For more information about X, see [Topic Title](mdc:url) in the Company Name documentation." | ||
| The style guide is maintained in this repo at `README.md`. | ||
|
|
||
| When writing or editing documentation in the `/docs` folder, follow all guidelines in the `README.md` file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are unused