Skip to content

Conversation

nightwing
Copy link
Collaborator

@nightwing nightwing commented Mar 18, 2025

  • removed .npmignore in favor of explicit whitelist since we only publish dist folder
  • removed yarn.lock since it was not included in published package and is generating annoying pull requests from dependabot
  • updated dependencies to the latests versions

@nightwing nightwing force-pushed the fix-deps branch 2 times, most recently from ff9725d to a77001a Compare March 18, 2025 20:51
Copy link
Member

@masad-frost masad-frost Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lock files are still good for consistent builds and avoiding supply chain attacks

Copy link
Member

@masad-frost masad-frost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately due to compliance we have to keep lockfiles for all packages we publish

@nightwing
Copy link
Collaborator Author

Ok, i have restored the lockfile, and updated it.

@nightwing nightwing merged commit 568ebbf into master Mar 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants