moving partition type and storage url to partition manifest #10032
+30
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
zehiko
added
the
exclude from changelog
abey79
approved these changes
May 23, 2025
Comment on lines
+90
to
+92
| /// Partition manifest mandatory field names. | ||
| pub const PARTITION_MANIFEST_PARTITION_TYPE_FIELD_NAME: &str = "rerun_partition_type"; | ||
| pub const PARTITION_MANIFEST_STORAGE_URL_FIELD_NAME: &str = "rerun_storage_url"; |
There was a problem hiding this comment.
What's the purpose of these constant? Are they returned by other endpoints? If so, would it be possibly to add the schema() method to the corresponding responses?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of append workflow changes, we're moving type and storage url to partition manifest. This is the necessary rerun side update.