Skip to content

Simple built-in URDF loader #10105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jun 4, 2025
Merged

Simple built-in URDF loader #10105

merged 20 commits into from
Jun 4, 2025

Conversation

emilk
Copy link
Member

@emilk emilk commented May 31, 2025

Related

What

Add built-in support for loading .urdf files.

Shortcomings

Testing

You can use these urdf meshes:

TODO

  • Some web support
  • Add support for other primitives than meshes
  • Log colors from URDF as albedo_factor overrides to Rerun
  • Try drag-dropping in an .urdf file in the native viewer
  • Try drag-dropping in an .urdf file in the web viewer
  • Handle non-relative mesh paths
  • Add an URDF to git lfs for testing?
  • Test animating a robot arm by logging joint angles separately
Screenshot 2025-05-31 at 11 17 44

Copy link

github-actions bot commented May 31, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
aa6eb07 https://rerun.io/viewer/pr/10105 +nightly +main

Note: This comment is updated whenever you push a commit.

@emilk emilk added enhancement New feature or request 📺 re_viewer affects re_viewer itself labels Jun 2, 2025
@emilk emilk force-pushed the gijs/urdf-loader branch from 54f25ae to be2dc1e Compare June 2, 2025 21:27
@emilk emilk marked this pull request as ready for review June 2, 2025 22:10
@emilk emilk force-pushed the gijs/urdf-loader branch from 9e618ff to 74e47cd Compare June 2, 2025 22:14
rgba: Vec4([r, g, b, a]),
} = color;
asset3d = asset3d.with_albedo_factor(
// TODO(emilk): is this linear or sRGB?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been a while since I had my computer graphics course, but I think Gazebo assumes linear colours.
This page on the colour model mentions the it's rendered using the Blinn-Phong shading model, which I think implies it's linear.

There's also this 10 year old issue on the RViz repo: ros-visualization/rviz#515 that mentions it's missing gamma correction 😄

@emilk emilk force-pushed the gijs/urdf-loader branch from 137ba93 to aa6eb07 Compare June 3, 2025 13:31
@emilk emilk merged commit 7c6d8d3 into main Jun 4, 2025
40 checks passed
@emilk emilk deleted the gijs/urdf-loader branch June 4, 2025 00:09
@oxkitsune oxkitsune mentioned this pull request Jun 4, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request include in changelog 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support URDF
2 participants