-
Notifications
You must be signed in to change notification settings - Fork 458
Simple built-in URDF loader #10105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple built-in URDF loader #10105
Conversation
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
rgba: Vec4([r, g, b, a]), | ||
} = color; | ||
asset3d = asset3d.with_albedo_factor( | ||
// TODO(emilk): is this linear or sRGB? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's been a while since I had my computer graphics course, but I think Gazebo assumes linear colours.
This page on the colour model mentions the it's rendered using the Blinn-Phong shading model, which I think implies it's linear.
There's also this 10 year old issue on the RViz repo: ros-visualization/rviz#515 that mentions it's missing gamma correction 😄
Co-authored-by: Gijs de Jong <[email protected]>
Related
What
Add built-in support for loading .urdf files.
Shortcomings
Testing
You can use these urdf meshes:
TODO