-
-
Notifications
You must be signed in to change notification settings - Fork 251
Show the number of errors and warnings in the Problems
tab's title
#1004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
fhammerschmidt
merged 19 commits into
rescript-lang:master
from
mediremi:playground-tweaks
May 3, 2025
Merged
Changes from 2 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
d21e5e6
Use Int.toString instead of Belt.Int.toString for ReScript v11+
mediremi 573b863
Use more padding and set max default content width in React and Conso…
mediremi 06bf524
Show error and problem counts in 'Problems' tab title
mediremi c5e8621
Only show syntax selection if there are at least 2 syntaxes to choose…
mediremi fd86598
Update TailwindCSS to v3.4.17 to get extended min-width, max-width, a…
mediremi 92bb2ea
Set min-width on problem counts
mediremi 7a4ce15
Only reset warning flags, not other config, when clicking warning fla…
mediremi ec20549
Add missing warning flag description
mediremi 9760eda
Remove warning flags that no longer exist
mediremi 8553e6b
Improve styles for warnings flags input
mediremi 39527e5
Remove warnings 61 and 109 from default warn flags
mediremi 6d80d6c
Refactor ToggleSelection component
mediremi cfaa584
Remove outdated TODOs
mediremi dad68a1
Remove unused OCaml variant in RescriptCompilerApi.Lang.t
mediremi 2f7cd58
Remove unused RescriptCompilerApi.Compiler.ocamlCompile
mediremi 5e74246
Remove warning flag descriptions for flags that no longer exist
mediremi 2384d4c
Merge branch 'master' into playground-tweaks
mediremi 7beeea0
Move problem counts to after 'Problems' tab title
mediremi 0afa602
Restore warnings flags reset value to support older compilers
mediremi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
onClick
instead ofonMouseDown
makes the tabs keyboard accessible - buttons with a click handler can be triggered withEnter
/Space
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might have been an optimisation so that
event.preventDefault()
gets invoked faster. Or maybe it was deliberate that it does not get focused.@ryyppy do you still remember?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there was most likely a good reason. I think it had something to do with touch event delay. Ultimately one should consider adapting a accessibility component lib like react-aria to have a fully accessible tab bar etc.