improve Package search sorting #860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jderochervlk is attempting to deploy a commit to the ReScript Association Team on Vercel. A member of the Team first needs to authorize it. |
fhammerschmidt
requested changes
May 13, 2024
src/Packages.res
Outdated
| ->Js.Array2.concat(parsePkgs(data2)) | ||
| ->Js.Array2.concat(parsePkgs(data3)) | ||
| ->Js.Array2.filter(pkg => { | ||
| if [/* Allow list of names */]->Js.Array2.includes(pkg.name) { |
There was a problem hiding this comment.
You could do a
let allowList = []somehwere at the beginning of the file already then you don't need the comment here.
src/Packages.res
Outdated
|
|
||
| Belt.Array.concat(filteredNpm, filteredUrls) | ||
| Belt.Array.concat(filteredNpm, filteredUrls)->Belt.Array.concat(filteredOutdated) |
There was a problem hiding this comment.
there is also Belt.Array.concatMany([])
fhammerschmidt
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.