Skip to content

Correct comparison operator in Array.every() method #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

WooWan
Copy link

@WooWan WooWan commented May 24, 2024

Fix typo in Array.every() comparison operator
Yay, my first contribution

let array = [1, 2, 3, 4]

//before
Console.log(array->Array.every(num => num > 4)) // true

//after
Console.log(array->Array.every(num => num <= 4)) // true

Copy link

vercel bot commented May 24, 2024

@WooWan is attempting to deploy a commit to the ReScript Association Team on Vercel.

A member of the Team first needs to authorize it.

@fhammerschmidt
Copy link
Member

Thank you, but the file you edited here is generated from ReScript Core's interface files:
So you would need to change it here: https://github.com/rescript-association/rescript-core/blob/main/src/Core__Array.resi#L531

@WooWan
Copy link
Author

WooWan commented May 25, 2024

Thanks for letting me know!
I created a new pull request in the rescript-core, I close this pull request

@WooWan WooWan closed this May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants