Skip to content

Remove chokidar #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 21, 2025
Merged

Remove chokidar #1096

merged 3 commits into from
May 21, 2025

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented May 19, 2025

This replaces the file watchers on the LSP server side.
For a while now, we can ask LSP clients to watch files.
As far as I can tell, all modern clients do support this.
Everything worked nicely for me in VS Code.

Part of #1094

@nojaf nojaf force-pushed the remove-chokidar branch from af52631 to 9cb7481 Compare May 20, 2025 12:47
@nojaf nojaf requested a review from zth May 20, 2025 12:48
@nojaf nojaf force-pushed the remove-chokidar branch from 9cb7481 to 3d11f18 Compare May 20, 2025 15:24
@zth
Copy link
Collaborator

zth commented May 20, 2025

Can we verify that this works on a non VSCode setup as well?

@nojaf
Copy link
Contributor Author

nojaf commented May 20, 2025

I asked @shulhi about this. Worked for him on neovim!

@zth
Copy link
Collaborator

zth commented May 21, 2025

Great! A changelog and then this should be good to go then!

@zth zth merged commit 42cdfd3 into rescript-lang:master May 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants