@rescript/runtime package
#7483
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great! Could you rebase to resolve the conflicts? |
cometkim
commented
May 18, 2025
| if checkDir path then | ||
| readDirectory path | ||
| |> List.map (fun name -> | ||
| collect ~checkDir ~maxDepth:(n - 1) |
There was a problem hiding this comment.
This needs to be made a bit more stable.
If users use a monorepo, they may still need to look upward to find the runtime package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6183
Issues:
yarn workspace @rescript/runtime clean(rewatch clean) doesn't work properlyrewatch buildandrescript cleanare not compatible.standard_library, not a regular dependency. Or breaks thebsccommand without a build system.@rescript/stdliband@rescript/beltas regular dependencies, we have to compromise with this.