Skip to content

Improve array pattern spread error message #7549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 15, 2025

Conversation

mediremi
Copy link
Contributor

For performance reasons, using array spread in pattern matching is not supported.

The current error message offers Array.sub and Belt.Array.slice as possible solutions, but with v12 having a stdlib, we should instead recommend Array.slice.

@mediremi mediremi marked this pull request as ready for review June 13, 2025 20:29
Copy link
Collaborator

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

@zth zth merged commit 1004d78 into rescript-lang:master Jun 15, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants