Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(body): Use css type selector for body background for outlook #1946

Open
wants to merge 19 commits into
base: canary
Choose a base branch
from
Open

fix(body): Use css type selector for body background for outlook #1946

wants to merge 19 commits into from

Conversation

hillac
Copy link

@hillac hillac commented Mar 8, 2025 •
edited
Loading

Background color style in body doesn't work in outlook web. Outlook converts body to a div and strips styles. For example the stripe-welcome demo email doesn't render correctly in outlook, there is no background. Outlook seems to respect type selectors so adding a style tag with body type selector fixes this.

See #662

May need to do this for every style applied to the body.

@vercel Vercel
Copy link

vercel bot commented Mar 8, 2025

@hillac is attempting to deploy a commit to the resend Team on Vercel.

A member of the Team first needs to authorize it.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 8, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: b8afcc8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

KayleeWilliams and others added 16 commits March 17, 2025 10:46
@KayleeWilliams @gabrielmfern
@dependabot @bukinoshita
feat(react-email): added a theme switcher to the dev preview (resend#…
b740a52 
…1749)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: gabriel miranda <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Bu Kinoshita <[email protected]>
@hautest @gabrielmfern
fix(cli): Correct typo in cliPacakgeLocation to cliPackageLocation (r…
cda2b70 
…esend#1918)
@renovate @gabrielmfern
fix(deps): update dependency esbuild to v0.25.0 [security] (resend#1904)
f582ba9 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: gabriel miranda <[email protected]>
@dependabot @gabrielmfern
chore(deps-dev): bump vite from 5.4.13 to 5.4.14 (resend#1899)
8545529 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @gabrielmfern
chore(deps-dev): bump vitest from 2.0.5 to 2.1.9 (resend#1898)
b0cbc88 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@gabrielmfern
chore(all): remove vitest from individual pacakges
d994cf3
@renovate @gabrielmfern
chore(deps): update dependency clsx to v2.1.1 (resend#1894)
c5ba696 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @gabrielmfern
chore(deps): update dependency @changesets/cli to v2.28.0 (resend#1893)
7332c2b 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@Sjoertjuh @gabrielmfern
feat(tailwind): extract pseudo classes to stylesheet (resend#1864)
08cb9c3 
Co-authored-by: gabriel miranda <[email protected]>
@gabrielmfern
fix(tailwind): Infinite loop during sanitization
0219c33 
cause by me
@gabrielmfern
chore(tailwind): Improve code for running Tailwind integration test (r…
d1c1628 
…esend#1935)
@gabrielmfern
chore(root): Improve caching of CI (resend#1936)
5d0f4ab
@gabrielmfern
chore(render): Remove duplicate code from renderAsync (resend#1934)
c334bce
@renovate @gabrielmfern
chore(deps): update dependency @types/node to v20.17.22 (resend#1940)
38d6538 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @gabrielmfern
chore(deps): update dependency @changesets/cli to v2.28.1 (resend#1939)
6b0686e 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@DavidHuie @gabrielmfern
fix(react-email): Detection of files with various export patterns (re…
28c0a99 
…send#1951)

Co-authored-by: gabriel miranda <[email protected]>
h4sohail and others added 3 commits March 20, 2025 09:58
@h4sohail
chore(deps): upgrade prettier to 3.5.3 (resend#1959)
7fc787f
@renovate
fix(deps): update dependency prismjs to v1.30.0 [security] (resend#1949)
30d0b6d 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@hillac @gabrielmfern
type selector style for body bg color
b8afcc8 
background color doesn't work in outlook for body
@gabrielmfern gabrielmfern force-pushed the canary branch 7 times, most recently from ceeaf0d to e7c671a Compare April 4, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hillac @KayleeWilliams @hautest @gabrielmfern @Sjoertjuh @DavidHuie @h4sohail