Skip to content

feat(react-email): Leverage Server Components for better UX #1947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 26 commits into
base: 4.0
Choose a base branch
from

Conversation

gabrielmfern
Copy link
Collaborator

  • use the oficial lottie react library
  • add initial draft for react-dom rendering
  • use portals, SO MUCH SIMPLER
  • lint
  • fix props name
  • wire up overwritten React and React DOM for the rendering to work with React 18
  • update to use flex layouts
  • add help icon on the bottom saying the rendering might differ
  • remove commented code
  • fix key error

gabrielmfern and others added 25 commits March 3, 2025 14:56
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Bu Kinoshita <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Lucas de França <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Bu Kinoshita <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Lucas de França <[email protected]>
@gabrielmfern gabrielmfern added the Package: react-email This is the CLI we generally use as just `email` on the temrinal. label Mar 10, 2025
@gabrielmfern gabrielmfern self-assigned this Mar 10, 2025
Copy link

changeset-bot bot commented Mar 10, 2025

⚠️ No Changeset found

Latest commit: abd17b4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-email ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 7:01pm
react-email-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 7:01pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: react-email This is the CLI we generally use as just `email` on the temrinal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant