Skip to content

chore(react-email): Add console.error on uncaught exceptions #2179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 99 commits into
base: canary
Choose a base branch
from
Open

chore(react-email): Add console.error on uncaught exceptions #2179

wants to merge 99 commits into from

Conversation

gabrielmfern
Copy link
Collaborator

For some time I noticed that when there was an uncaught exception the process would just close without any feedback. The problem
was that we were simply hooking into the uncaughtException event emitted on the process and were not writing it into the console
and instead closing the process with code 1. This PR fixes it by simply logging the error before closing the process.

KayleeWilliams and others added 30 commits April 19, 2025 13:17
@KayleeWilliams @gabrielmfern
@dependabot @bukinoshita
feat(react-email): added a theme switcher to the dev preview (#1749)
a8cf2a9 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: gabriel miranda <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Bu Kinoshita <[email protected]>
@Sjoertjuh @gabrielmfern @bukinoshita
feat(tailwind): extract pseudo classes to stylesheet (#1864)
fbc79ab 
Co-authored-by: gabriel miranda <[email protected]>
@gabrielmfern @bukinoshita
fix(tailwind): Infinite loop during sanitization
f2d526f 
cause by me
@gabrielmfern @bukinoshita
chore(tailwind): Improve code for running Tailwind integration test (#…
e8af858 
…1935)
@renovate @bukinoshita
chore(deps): update dependency @types/node to v20.17.22 (#1940)
4aa336a 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @bukinoshita
chore(deps): update dependency @changesets/cli to v2.28.1 (#1939)
258d7e0 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@gabrielmfern @bukinoshita
chore(root): Lint
d4f33fe
@gabrielmfern @bukinoshita
fix(react-email): Rebase artifact with default active view
d9397ee
@gabrielmfern @bukinoshita
fix locks
ba2b831
@gabrielmfern @bukinoshita
fix(root): Duplicated turbo package config
1baab85
@gabrielmfern @bukinoshita
chore: Enter pre-release
1f26ff9
@github-actions @bukinoshita
chore(root): Version packages (canary) (#2064)
2fdbbae 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@dependabot @bukinoshita
chore(deps-dev): bump vite from 5.4.14 to 5.4.17 (#2062)
410681d 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@renovate @bukinoshita
chore(deps): update dependency vite to v5.4.17 [security] (#2033)
5369062 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@bukinoshita @gabrielmfern
chore: lint workflow (#2024)
91bbad7 
Co-authored-by: gabriel miranda <[email protected]>
@gabrielmfern @bukinoshita
chore(create-email): Incresae timeout for type checking test
2f9e674
@bukinoshita
fix(create-email): linter (#2023)
170cee4
@bukinoshita @gabrielmfern
fix(tailwind): linter (#2021)
ed4f9ed 
Co-authored-by: gabriel miranda <[email protected]>
@bukinoshita
fix(benchmarks): linter (#2022)
6c787fc
@bukinoshita @gabrielmfern
fix(demo): linter (#2018)
b63183a 
Co-authored-by: gabriel miranda <[email protected]>
@bukinoshita @gabrielmfern
fix(web): linter (#2019)
a651762 
Co-authored-by: gabriel miranda <[email protected]>
@gabrielmfern @bukinoshita
feat(ci): Separate actions for versioning canary/main (#2075)
9c8cd18
@gabrielmfern @bukinoshita
feat(ci): Automated canary releases (#2076)
8367b54
@gabrielmfern @bukinoshita
fix(react-email): Dependents of dependents of email templates not cau…
7abd4dc 
…sing hot reloads (#2083)
@gabrielmfern @bukinoshita
fix(react-email): No error with missing default function export (#2084)
754b0fe
@gabrielmfern @bukinoshita
feat(create-email): Use latest from specified tag for react-email a…
ea8f561 
…nd `@react-email/components` (#2085)
@gabrielmfern @bukinoshita
fix(root): changeset (#2086)
9d70c5f
@github-actions @bukinoshita
chore(root): Version packages (canary) (#2087)
a82845d 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@thena-seer @gabrielmfern @bukinoshita
feat(render): Separate pretty from render (#1906)
304851a 
Co-authored-by: gabriel miranda <[email protected]>
@CHC383 @gabrielmfern @bukinoshita
build(deps): use caret range for package dependencies (#2028)
d037db8 
Co-authored-by: gabriel miranda <[email protected]>
github-actions bot and others added 4 commits April 21, 2025 14:40
@github-actions
chore(root): Version packages (canary) (#2175)
cbe8113 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency postcss to v8.5.3 (#2126)
1e0a99a 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@gabrielmfern
chore(react-email): Add console.error on uncaught exceptions
a5fc35a
@gabrielmfern
add missing function call
6168b65
@gabrielmfern gabrielmfern added the Package: react-email This is the CLI we generally use as just `email` on the temrinal. label Apr 22, 2025
@gabrielmfern gabrielmfern self-assigned this Apr 22, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 22, 2025

⚠️ No Changeset found

Latest commit: 6168b65

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Apr 22, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-email ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2025 5:58pm
react-email-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2025 5:58pm

@gabrielmfern gabrielmfern force-pushed the canary branch 7 times, most recently from 643b95a to 35a000c Compare April 25, 2025 11:44
@gabrielmfern gabrielmfern force-pushed the canary branch 4 times, most recently from ae17b61 to e62d722 Compare May 2, 2025 14:04
@gabrielmfern gabrielmfern force-pushed the canary branch 6 times, most recently from 2eba90b to 98c3d9b Compare May 16, 2025 13:02
@gabrielmfern gabrielmfern force-pushed the canary branch 3 times, most recently from 0074ddf to f7e553f Compare May 20, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gabrielmfern gabrielmfern

Labels
Package: react-email This is the CLI we generally use as just `email` on the temrinal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gabrielmfern @KayleeWilliams @Sjoertjuh @bukinoshita @thena-seer @CHC383