Skip to content

feat: Separate preview server from react-email #2182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 38 commits into
base: canary
Choose a base branch
from

Conversation

gabrielmfern
Copy link
Collaborator

@gabrielmfern gabrielmfern commented Apr 23, 2025

This implements the code for email dev, email build and email start to work with a separate package for the preview server.

The package is going to be called @react-email/preview-server. If the user tries to run email dev, email build or email start without the package, the CLI now prompts the user to install it before actually running the commands.

For building, we just copy the code from @react-email/preview-server instead of from the CLI react-email.

@gabrielmfern gabrielmfern self-assigned this Apr 23, 2025
Copy link

changeset-bot bot commented Apr 23, 2025

⚠️ No Changeset found

Latest commit: b2df185

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-email ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2025 3:35pm
react-email-demo ❌ Failed (Inspect) May 16, 2025 3:35pm

@gabrielmfern gabrielmfern marked this pull request as draft April 23, 2025 11:42
@gabrielmfern gabrielmfern added the Package: react-email This is the CLI we generally use as just `email` on the temrinal. label Apr 23, 2025
@@ -0,0 +1,82 @@
import path from 'node:path';
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I duplicated the code that is still in the CLI here for now, and we can think of someway to share this code between the preview server & CLI later on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: react-email This is the CLI we generally use as just `email` on the temrinal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant