-
Notifications
You must be signed in to change notification settings - Fork 759
feat: Separate preview server from react-email
#2182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: canary
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
d008992
to
060cc5d
Compare
643b95a
to
35a000c
Compare
ae17b61
to
e62d722
Compare
060cc5d
to
b3eaa56
Compare
@@ -0,0 +1,82 @@ | |||
import path from 'node:path'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I duplicated the code that is still in the CLI here for now, and we can think of someway to share this code between the preview server & CLI later on
… the preview server package instead of the react-email one
8634bb3
to
9f178d3
Compare
This implements the code for
email dev
,email build
andemail start
to work with a separate package for the preview server.The package is going to be called
@react-email/preview-server
. If the user tries to runemail dev
,email build
oremail start
without the package, the CLI now prompts the user to install it before actually running the commands.For building, we just copy the code from
@react-email/preview-server
instead of from the CLIreact-email
.