Skip to content

Make Contact TypeScript interfaces nullable rather than optional#706

Closed
max-programming wants to merge 39 commits into
resend:canaryfrom
max-programming:ts-null-types
Closed

Make Contact TypeScript interfaces nullable rather than optional#706
max-programming wants to merge 39 commits into
resend:canaryfrom
max-programming:ts-null-types

Conversation

@max-programming
Copy link
Copy Markdown

@max-programming max-programming commented Oct 22, 2025 •
edited by cubic-dev-ai Bot
Loading

This PR fixes #646 by making fields of first name and last name from TS interfaces & types for Contact nullable and removing optional (undefined) from them

Summary by cubic

Switch Contact and UpdateContactOptions first_name/last_name from optional to nullable so these fields are always present and use null instead of undefined. Addresses Linear issue #646.

  • Migration
    • Check for null (not undefined) on Contact.first_name and last_name.
    • Include firstName and lastName in UpdateContactOptions; pass null when not updating them.

lucasfcosta and others added 30 commits October 21, 2025 14:48
@lucasfcosta @gabrielmfern
feat: get inbound emails v0 (resend#641)
ab1d509
@renovate @gabrielmfern
chore(deps): update dependency @biomejs/biome to v2.2.4 (resend#537)
ae5b029 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@lucasfcosta @vcapretz @gabrielmfern
feat: bump version for inbound release (resend#642)
a0b0943 
Co-authored-by: Vitor Capretz <vitor@resend.com>
@gabrielmfern
chore: bump to 6.2.0-canary.1 (resend#649)
c0b1b4f
@renovate @gabrielmfern
chore(deps): update dependency @types/node to v22.18.8 (resend#638)
e648bb9 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @gabrielmfern
chore(deps): update dependency typescript to v5.9.3 (resend#645)
34b2267 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @gabrielmfern
chore(deps): update tj-actions/changed-files digest to d6f020b (resen…
98fa90c 
…d#651)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @gabrielmfern
chore(deps): update pnpm to v10.18.0 (resend#653)
5d9d306 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @gabrielmfern
chore(deps): update dependency @biomejs/biome to v2.2.5 (resend#652)
a5df0a5 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @gabrielmfern
chore(deps): update dependency @types/react to v19.2.0 (resend#640)
9e4b04a 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@lucasfcosta @gabrielmfern
feat: show headers in response (resend#657)
294aeba
@lucasfcosta @gabrielmfern
chore: release new canary for headers (resend#658)
bfb4026
@TyMick @gabrielmfern
chore: improve PR title check error (resend#664)
2a5fd6d 
Co-authored-by: Gabriel Miranda <gabrielmfern@outlook.com>
@lucasfcosta @gabrielmfern
feat: move emails inbound method to emails.receiving.<method> (resend…
2022031 
…#666)
@lucasfcosta @gabrielmfern
feat: move attachment inbound methods to be nested (resend#667)
54569ba
@lucasfcosta @gabrielmfern
feat: add inbound listing method (resend#668)
236c533
@lucasfcosta @gabrielmfern
feat: add pagination for inbound email attachments (resend#670)
64a674f
@renovate @gabrielmfern
chore(deps): update pnpm to v10.18.2 (resend#659)
ffe4fce 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @gabrielmfern
chore(deps): update dependency @types/node to v22.18.9 (resend#669)
d4e34ee 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @gabrielmfern
chore(deps): update pnpm/action-setup digest to 41ff726 (resend#665)
798d80b 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@TyMick @gabrielmfern
feat: partial (API Keys, Audiences, and Contacts) non-mocked test cov…
41b7f7b 
…erage (resend#663)
@isabellaaquino @gabrielmfern
feat: bump version (resend#675)
aae3602
@Cisneiros @CarolinaMoraes
@cubic-dev-ai @lucasfcosta @renovate @vcapretz @gabrielmfern @cassiozen @bukinoshita
feat: merge project preview branches (resend#680)
653a6a3 
Co-authored-by: Carolina de Moraes Josephik <32900257+CarolinaMoraes@users.noreply.github.com>
Co-authored-by: Carolina de Moraes Josephik <carolina.moraesjosephik@gmail.com>
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Co-authored-by: Lucas da Costa <lucas@lucasfcosta.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Vitor Capretz <vitor@resend.com>
Co-authored-by: Gabriel Miranda <gabrielmfern@outlook.com>
Co-authored-by: Vitor Capretz <capretzvitor@gmail.com>
Co-authored-by: Cassio Zen <cassiozen@gmail.com>
Co-authored-by: Bu Kinoshita <6929565+bukinoshita@users.noreply.github.com>
@lucasfcosta @gabrielmfern
feat: download from API's signed URLs instead of proxied routes (rese…
27a9a6c 
…nd#676)
@zenorocha @gabrielmfern
fix: repo urls (resend#679)
4ba8340
@lucasfcosta @gabrielmfern
feat: allow creating domain with capabilities through the api (resend…
afc815a 
…#682)
@bukinoshita @gabrielmfern
feat: add verify webhooks (resend#636)
4747aea
@lucasfcosta @gabrielmfern
feat: avoid downloading attachments ourselves (resend#685)
def00a1
@lucasfcosta @gabrielmfern
chore: bump to canary 6.3.0-canary.1 (resend#687)
de2e0e3
@joaopcm @lucasfcosta
@renovate @vcapretz @gabrielmfern @TyMick @isabellaaquino @Cisneiros @CarolinaMoraes @cubic-dev-ai @cassiozen @bukinoshita @zenorocha
chore: limited variable types (resend#692)
f6b5102 
Co-authored-by: Lucas da Costa <lucas@lucasfcosta.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Vitor Capretz <vitor@resend.com>
Co-authored-by: Gabriel Miranda <gabrielmfern@outlook.com>
Co-authored-by: Ty Mick <5317080+TyMick@users.noreply.github.com>
Co-authored-by: Isabella Aquino <isabella@resend.com>
Co-authored-by: Alexandre Cisneiros <Cisneiros@users.noreply.github.com>
Co-authored-by: Carolina de Moraes Josephik <32900257+CarolinaMoraes@users.noreply.github.com>
Co-authored-by: Carolina de Moraes Josephik <carolina.moraesjosephik@gmail.com>
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Co-authored-by: Vitor Capretz <capretzvitor@gmail.com>
Co-authored-by: Cassio Zen <cassiozen@gmail.com>
Co-authored-by: Bu Kinoshita <6929565+bukinoshita@users.noreply.github.com>
Co-authored-by: Zeno Rocha <zno.rocha@gmail.com>
@max-programming max-programming requested a review from a team as a code owner October 22, 2025 14:24
@max-programming max-programming changed the title Make Contact TypeScript interfaces **nullable** rather than optional Make Contact TypeScript interfaces nullable rather than optional Oct 22, 2025
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Oct 22, 2025

Open in StackBlitz

npm i https://pkg.pr.new/resend/resend-node/resend@706

commit: 9dd1001

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 22, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@gabrielmfern
Copy link
Copy Markdown
Member

gabrielmfern commented Nov 19, 2025

closing in favor of #757

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

@lucasfcosta lucasfcosta Awaiting requested review from lucasfcosta lucasfcosta is a code owner automatically assigned from resend/engineering

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TypeScript interfaces missing null for contact name fields

10 participants

@max-programming @gabrielmfern @lucasfcosta @TyMick @isabellaaquino @Cisneiros @zenorocha @bukinoshita @joaopcm @vieiralucas