fix: resolve key error by initializing target dictionary with _dict and converting response in frappe dict

[karm1000]

No description provided.

[greptile-apps]

Confidence Score: 4/5

Both changes are narrowly scoped and address the reported KeyError; the main risk is the two-step serialisation in parser.py if the OpenAI SDK ever returns non-serialisable data.

The response_merger.py change is straightforward and low-risk. The parser.py change works correctly for current OpenAI SDK responses, but the json.dumps call sits outside to_dict's error handling, so a non-serialisable value would produce a raw TypeError rather than a graceful message — a scenario worth guarding against.

transaction_parser/transaction_parser/ai_integration/parser.py — the JSON round-trip error path.

Important Files Changed

Filename	Overview
transaction_parser/transaction_parser/ai_integration/parser.py	Adds a JSON round-trip (json.dumps → to_dict) to deeply convert the OpenAI response into frappe._dict objects; the split error-handling path is a minor concern.
transaction_parser/transaction_parser/utils/response_merger.py	Replaces bare {} with _dict() when initialising a new nested object slot, ensuring newly created sub-dicts are frappe._dict and consistent with the top-level response wrapping in init.

_{Reviews (1): Last reviewed commit: "fix: resolve key error by initializing t..." | Re-trigger Greptile}

[coderabbitai]

Warning

Review limit reached

@karm1000, we couldn't start this review because you've used your available PR reviews for now.

Your plan includes 1 review of capacity. Refill in 31 minutes and 3 seconds.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more review capacity refills, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5c48653b-6c63-4348-ba8c-cbd665c5a948

📥 Commits

Reviewing files that changed from the base of the PR and between 8da2c51 and 1698186.

📒 Files selected for processing (2)

• transaction_parser/transaction_parser/ai_integration/parser.py
• transaction_parser/transaction_parser/utils/response_merger.py

📝 Walkthrough

Walkthrough

This PR contains two targeted fixes for data handling in the transaction parser. The parser module now JSON round-trips API responses during conversion by adding a json import and serializing response output through json.dumps() before rehydration. The response merger module initializes nested object containers with frappe._dict() instead of plain dictionaries when merging objects with missing or null fields. Both changes maintain existing behavior while improving data type consistency.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	No pull request description was provided by the author, making it impossible to assess whether the description relates to the changeset.	Provide a description explaining the key error issue, how the two changes fix it, and any testing performed to verify the fix.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes both main changes: initializing dictionary with _dict and converting response in frappe dict, directly addressing the key error fixes in the changeset.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}