Add function node_types_rebuild() #133
Open
+31
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mglaman
requested changes
Dec 9, 2023
|
|
||
| function node_types_rebuild(): void | ||
| { | ||
| $tags = \Drupal::config('node_type')->getCacheTags(); |
There was a problem hiding this comment.
I don't think this is valid. There isn't a node_type config object.
Comment on lines
+31
to
+82
| $tags[] = 'config:node_type_list'; | ||
| Cache::invalidateTags($tags); |
There was a problem hiding this comment.
I'm not sure if this is correct. We probably want the value of getListCacheTags from the node_type entity type definition.
src/functions/node.php
Outdated
Comment on lines
33
to
84
| $storage = \Drupal::service('config.storage'); | ||
| assert($storage instanceof StorageCacheInterface); | ||
| $storage->resetListCache(); |
There was a problem hiding this comment.
Instead of this, we could load all node_type entities, collect their getCacheTags and use Cache::mergeTags to invalidate all of their individual cache tags.
darrenoh
force-pushed
the
add-node_types_rebuild
branch
from
0cfc3b9
to
78bb637
Compare
darrenoh
force-pushed
the
add-node_types_rebuild
branch
from
78bb637
to
1e3cf30
Compare
darrenoh
force-pushed
the
add-node_types_rebuild
branch
from
1e3cf30
to
d0d8479
Compare
darrenoh
force-pushed
the
add-node_types_rebuild
branch
from
d0d8479
to
fbe835e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.