feat: add neoforge platform support - #1540
Open
TheFaser wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
I think this PR is ready. It might be worth testing it with other plugins that don't relate to PacketEvents, but I'm already using this PacketEvents on NeoForge for my project and there are no errors. Except for PacketEncoder, which I had to fix |
TheFaser
marked this pull request as ready for review
August 1, 2026 05:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1320
This isn’t finished yet, because I have library issue on NeoForge. If you try to run packetevents-neoforge and adventure-platform-neoforge right now, you’ll get an error message.
I also haven’t tested functionality and I’m not sure everything works at the moment, because (as I wrote above) I haven’t been able to resolve library conflict yet and because of that I can’t test PacketEvents together with my plugins. If you make the listeners directly in PacketEvents, that already works.
I currently have no ideas on how to solve this problem and I'm not insisting that NeoForge must be supported by PacketEvents but this platform is very similar to Fabric so supporting it isn't difficult.
UPD: I think the Adventure dependency issue also occurs on Fabric, so to solve it, we need to change loading this library, or update version to 5.x for NeoForge and Fabric