Added QR code scan and verify functions#1
Merged
richardyrh merged 5 commits intorichardyrh:masterfrom May 4, 2020
axmmisaka:scanner
Merged
Added QR code scan and verify functions#1richardyrh merged 5 commits intorichardyrh:masterfrom axmmisaka:scanner
richardyrh merged 5 commits intorichardyrh:masterfrom
axmmisaka:scanner
Conversation
as mentioned above TODO: image loading might have flaws tbh
Contributor
Author
|
I force-pushed again in light of some security compromise |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR require some commits made by @william-lyh who mistakenly PRed in his own repo here: yhwli#1
I changed image preview to using canvas so that it could be easily converted to image data array, nevetheless this might be a problem on old browsers and those with crappy cpu, like if somebody wanna browse this with raspberrypi performance will be screwed
There are some TODOs with image preview, might be able to change it to instant one some time later.
ggwp