Prevent warnings if the app isn't setting a Content-Type #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If (for whatever reason) your app isn't setting a Content-Type header there's no point in continuing with the CSRF Currently CSRFBlock warns something like: Use of uninitialized value $ct in pattern match (m//) at /PATH/TO/lib/site_perl/5.12.4/Plack/Middleware/CSRFBlock.pm line 125. Yes, the app needs fixing, but there's no reason why this middleware shouldn't DTRT and avoid spitting out warnings.
|
hey @chiselwright, I actually hadn't noticed your PR here before, but I had already fixed this same issue in my branch (in a slightly more succinct way, I think throughnothing@4008918#L0R145). Since it seems like @rintaro is not really interested in looking at any PR's or maintaining this project at the moment, I've been keeping some modifications in my fork. I've added support for an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If (for whatever reason) your app isn't setting a Content-Type header there's no point in continuing with the CSRF
Currently CSRFBlock warns something like:
Use of uninitialized value $ct in pattern match (m//) at /PATH/TO/lib/site_perl/5.12.4/Plack/Middleware/CSRFBlock.pm line 125.
Yes, the app needs fixing, but there's no reason why this middleware shouldn't DTRT and avoid spitting out warnings.