Skip to content

Conversation

mattp-
Copy link

@mattp- mattp- commented Sep 16, 2012

$env should be passed to token_not_found consistently, except it is not on form POST.

$env should be passed to token_not_found consistently, except it is not on form POST.
@throughnothing
Copy link

@mattp, hey, it looks like @rintaro is not really responding to any PR's here, but I've got a fork that I've been doing updates to (and have a PR in here as well). I was going to pull your PR into my repo, but after looking at it, it looks like the real bug is that he passes $env to token_not_found in the other places, since the token_not_found sub doesn't even use that parameter.

I think it should just be removed in the other places. If you're using this module and interested in making it better, I'm interested in that as well and may try to do a refactor in my branch when I get some time to make the code a little cleaner/more robust (I'm also running across some unicode issues with it I believe that I haven't had time to look into). Just wanted to give you a heads up in case you were interested. Thanks.

@throughnothing
Copy link

@mattp, just realized he is using @_ in the function, which would use $env if passed in. Really don't like the way he's doing that! (More reason to refactor :) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants