Skip to content

chore: deploy hadolint dockerfile linter #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kbroch-rivosinc
Copy link
Collaborator

WIP: still need to add hadolint binary
This lints dockerfiles for best practices
fixes #693

WIP: still need to add hadolint binary
This lints dockerfiles for best practices
fixes #693
@kbroch-rivosinc kbroch-rivosinc marked this pull request as draft April 29, 2025 15:13
@kbroch-rivosinc kbroch-rivosinc self-assigned this Apr 29, 2025
@ThinkOpenly
Copy link
Collaborator

WIP: still need to add hadolint binary This lints dockerfiles for best practices fixes #693

Does this produce FAILs, or just information that can be ignored?

@kbroch-rivosinc
Copy link
Collaborator Author

WIP: still need to add hadolint binary This lints dockerfiles for best practices fixes #693

Does this produce FAILs, or just information that can be ignored?

The default cfg against main is failing (the default fail threshold is info). There are lots of cfg options: https://github.com/hadolint/hadolint?tab=readme-ov-file#configure

Let's continue the discussion @dhower-qc has started in the issue on what we want to change in the default cfg and I'll add that to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add hadolint dockerfile linter to pre-commit checks
2 participants