Skip to content

feat: add resolved_arch tarball to deploy #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add resolved_arch tarball to deploy #757

wants to merge 1 commit into from

Conversation

dhower-qc
Copy link
Collaborator

No description provided.

@dhower-qc dhower-qc requested a review from AFOliveira May 9, 2025 18:47
@dhower-qc dhower-qc requested a review from ThinkOpenly as a code owner May 9, 2025 18:47
AFOliveira
AFOliveira reviewed May 9, 2025
View reviewed changes
lib/deploy.sh
<li>
For example, you can find <a href="$PAGES_URL/resolved_arch/ext/Sm.yaml">Sm.yaml</a> at $PAGES_URL/resolved_arch/ext/Sm.yaml
</li>
<ul>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not super sure, but isn't this \ul?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

close. :-)

</ul>

ThinkOpenly
ThinkOpenly requested changes May 12, 2025
View reviewed changes
Copy link
Collaborator

@ThinkOpenly ThinkOpenly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who's the expected consumer of this artifact? Is this a possible solution to providing "data" without "tools"?

lib/deploy.sh
Comment on lines +78 to +79
tar czf resolved_arch.tar.gz gen/resolved_arch/_
mv resolved_arch.tar.gz $DEPLOY_DIR/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One line?

tar czf $DEPLOY_DIR/resolved_arch.tar.gz gen/resolved_arch/_

lib/deploy.sh
<li>
For example, you can find <a href="$PAGES_URL/resolved_arch/ext/Sm.yaml">Sm.yaml</a> at $PAGES_URL/resolved_arch/ext/Sm.yaml
</li>
<ul>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

close. :-)

</ul>

@dhower-qc
Copy link
Collaborator Author

Who's the expected consumer of this artifact? Is this a possible solution to providing "data" without "tools"?

Exactly. This would provide the resolved data only for anyone that just wants to see that.

@ThinkOpenly
Copy link
Collaborator

Who's the expected consumer of this artifact? Is this a possible solution to providing "data" without "tools"?

Exactly. This would provide the resolved data only for anyone that just wants to see that.

I wonder if we should make that content into an occasional "release" artifact. I think you can drop whatever binaries/files you want into an arbitrary release. I see you can also mark it "Set as a pre-release", so it would be more clearly "not validated data, use as your own risk" (hopefully).

(This is not an "instead of" proposal, but "in addition to".)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AFOliveira AFOliveira AFOliveira left review comments

@ThinkOpenly ThinkOpenly ThinkOpenly requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhower-qc @ThinkOpenly @AFOliveira