rz table view refactoring#6456
Open
ashishk15678 wants to merge 5 commits into
Open
Conversation
ashishk15678
requested review from
Rot127,
b1llow,
kazarmy,
notxvilka,
ret2libc,
thestr4ng3r and
wargio
as code owners
Codecov Report❌ Patch coverage is Additional details and impacted files
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
notxvilka
requested changes
Jun 3, 2026
|
|
||
| RZ_API bool rz_table_view_query(RZ_NONNULL RzTableView *view, RZ_NULLABLE const char *q) { | ||
| rz_return_val_if_fail(view && view->table, false); | ||
| return rz_table_query(view->table, q); |
Contributor
There was a problem hiding this comment.
You need to "run" the query here. The whole point is not to modify the original table.
| return transpose; | ||
| } | ||
|
|
||
| RZ_API RZ_OWN RzTableView *rz_table_view_new(RZ_NONNULL const RzTable *t) { |
Contributor
There was a problem hiding this comment.
To be able to handle multiple queries you need to have a function of creating rztableview out of the rztableview
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
RZ_APIfunction and struct this PR changes.RZ_API).Detailed description
After querying any table the output now goes to
RzTableViewand associated functions , so that the querying can be better and more optimized and the results that were not part of the query donot automatically get dropped after querying.Test plan
Existing tests and new unit test
test_table_viewClosing issues
Linked #1961
...