chore(deps): upgrade eframe/egui 0.33 to 0.35 - #69
Merged
Conversation
Bumps eframe and egui_extras to 0.35, which requires Rust 1.92, so the workspace MSRV moves from 1.88 to 1.92. Ports the GUI to the egui 0.35 API: - eframe::App::update(ctx) becomes App::ui(ui); the root now hands a Ui instead of a Context, so the panel methods take a Ui and reach the Context via ui.ctx() for the modals and file dialogs. - TopBottomPanel and SidePanel are unified into Panel (Panel::top, Panel::bottom, Panel::left), show(ui, ..) replaces show(ctx, ..), and default_width/min_width become default_size/min_size. - TextEdit::frame now takes a Frame, so the frameless inputs use Frame::NONE (the Button frame(bool) call is unchanged). - ctx.style()/set_style() are gone: theme.rs uses all_styles_mut so the dark palette holds across theme variants, and the modal window frames use style_of(ctx.theme()). - The memoized highlight cache get() now returns a reference, so the result is cloned. - The repaint-convergence test drives the panels through Context::run_ui, which yields a root Ui like the real frame (Context::run was removed). fmt, clippy -D warnings, and the full test suite pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Upgrades
eframeandegui_extrasfrom 0.33 to 0.35 and ports the GUI to the new egui API.Because 0.35 requires Rust 1.92, the workspace MSRV moves from 1.88 to 1.92.
egui 0.35 API changes ported
eframe::App::update(ctx)becomesApp::ui(ui). The root now hands aUiinstead of aContext, so the panel methods take aUiand reach theContextviaui.ctx()for the modals and file dialogs.TopBottomPanelandSidePanelare unified intoPanel(Panel::top,Panel::bottom,Panel::left),show(ui, ..)replacesshow(ctx, ..), anddefault_width/min_widthbecomedefault_size/min_size.TextEdit::framenow takes aFrame, so the frameless inputs useFrame::NONE. TheButton::frame(bool)call is unchanged.ctx.style()/set_style()are gone.theme.rsusesall_styles_mutso the dark palette holds across theme variants, and the modal window frames usestyle_of(ctx.theme()).get()now returns a reference, so the result is cloned.Context::run_ui, which yields a rootUilike the real frame (Context::runwas removed).Verification
cargo build --workspace: cleancargo clippy --workspace --all-targets -- -D warnings: cleancargo fmt --all --check: cleancargo test --workspace: 119 passed, 0 failedNot yet verified: the rendered UI (panel sizing, frameless inputs, forced-dark theme) needs a real window to eyeball.
Follow-up
The MSRV bump to 1.92 means the AUR, Flatpak, and CI build environments need Rust >= 1.92 before this ships.