chore(deps): bump dependencies, raise MSRV, and unignore the fuzzy_find doctest - #70
Merged
Merged
Conversation
Update clap, libc, ratatui, ratatui-textarea, serde and serde_json to their latest patch releases, and refresh the lockfile for transitive updates (cc, displaydoc, either, event-listener, redox_syscall, toml, webbrowser).
The example was marked `ignore`, so it was never compiled or executed. Add the missing import and drop the marker so the example is verified by `cargo test --doc`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Routine dependency maintenance plus a doctest fix in
apic-core.Dependency bumps (
Cargo.toml,Cargo.lock)clap4.6.1 to 4.6.4,libcto 0.2.189,ratatuito 0.30.2,ratatui-textareato 0.9.2,serdeto 1.0.229,serde_jsonto 1.0.151.cc,displaydoc,either,event-listener,redox_syscall,toml,toml_parser,webbrowser.0.2/0.30style requirements.MSRV raised from 1.92 to 1.97 in
Cargo.toml.Doctest fix (
apic-core/src/fuzzy.rs)The
fuzzy_findexample was marked```ignore, so it was never compiled or run. It now has the missinguse apic_core::fuzzy::fuzzy_find;import and runs for real undercargo test --doc.Verification
Run locally on rustc 1.97.1:
cargo fmt --all --check, cleancargo clippy --workspace --all-targets -- -D warnings, cleancargo test --workspace, 258 tests passed across 6 targets, 0 failedcargo test --doc -p apic-core, 1 passed, the previously ignoredfuzzy_findexample now executesNote for review
The MSRV bump to 1.97 is worth a second look. CI installs
dtolnay/rust-toolchain@stablerather than a pinned version, so nothing in the pipeline actually enforces or verifies the declared MSRV, and I could not test against 1.92 because only stable is installed locally. If none of these dependency bumps genuinely require 1.97, this narrows the supported toolchain range for downstream users without a concrete reason. Happy to drop it back to 1.92 if it was incidental.