-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add Mantine theme #4496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mantine theme #4496
Conversation
@zfarhad Yes, @jasny is correct. We are only accepting critical fixes to the v5 release. Please make this change into the |
Also, feel free to join the Friday meeting mentioned in the pinned issue |
Sounds great, I didn't know you were developing v6. So I will prepare the theme based on the rjsf-v6 branch and submit a new PR request on it. |
Is there anything I can do to help get this over the line? |
@zfarhad Have you had a chance to make your changes against the |
@zfarhad I've merged a few PRs with updates and fixes from |
@heath-freenome Sorry for my late, I will migrate the theme to the rjsf-v6 branch later this week |
@zfarhad Great job! I don't know if this has been addressed in v6 layout. All the submit buttons for mantine theme are off in playground. default theme: ![]() ![]() |
…chakra-react-select
Reviewer feedback
@zfarhad still looking forward to seeing this rebased to the |
…sing them to a UI component
@zfarhad Just a reminder that we are not accepting any new features into the main build. Can you rebase your PR onto the |
@heath-freenome I've rebased the theme on the rjsf-v6 branch, it's ready now. Do I need to open a new PR for merging or will you continue with this one? |
Can you update this PR to merge into the |
I changed the base branch to rjsf-v6 but I couldn't change the head branch of the pull request, So I have created a new PR to merge into rjsf-v6. |
@zfarhad can we close this? |
Done |
Reasons for making this change
Added a new theme using Mantine UI library (@mantine/core, @mantine/hooks, @mantine/dates) for react-jsonschema-form, addressing the request in issue #4289 (fixes #4289). This theme provides a modern, customizable UI component set that integrates well with RJSF's form generation capabilities.
The Mantine theme offers:
Checklist
npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:update
to update snapshots, if needed.